Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mono] Clean up the type checks for Vector64/128 #65318

Closed
Tracked by #43051
fanyang-mono opened this issue Feb 14, 2022 · 1 comment · Fixed by #65486
Closed
Tracked by #43051

[Mono] Clean up the type checks for Vector64/128 #65318

fanyang-mono opened this issue Feb 14, 2022 · 1 comment · Fixed by #65486
Assignees
@fanyang-mono
Labels
area-Codegen-LLVM-mono area-Codegen-meta-mono
Milestone
7.0.0

Comments

@fanyang-mono
Copy link
Member

fanyang-mono commented Feb 14, 2022 •
edited
Loading

Refer to #65086 (comment)

Does types for vector arguments of each case.
@fanyang-mono fanyang-mono added this to the 7.0.0 milestone Feb 14, 2022
@fanyang-mono fanyang-mono self-assigned this Feb 14, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI untriaged New issue has not been triaged by the area owner labels Feb 14, 2022
@ghost
Copy link

ghost commented Feb 14, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Refer to #65086 (comment)

Basically, do type checks of the arguments and return at the beginning of emit_sri_vector in simd-intrinsics.c and remove the check from individual cases.

Author: fanyang-mono
Assignees: fanyang-mono
Labels:

area-CodeGen-coreclr, untriaged
Milestone: 7.0.0

@fanyang-mono fanyang-mono mentioned this issue Feb 14, 2022
Open
58 tasks
@fanyang-mono fanyang-mono added area-Codegen-LLVM-mono area-Codegen-meta-mono and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI untriaged New issue has not been triaged by the area owner labels Feb 14, 2022
@fanyang-mono fanyang-mono mentioned this issue Feb 14, 2022
Merged
This was referenced Feb 22, 2022
Merged
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 23, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 8, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fanyang-mono fanyang-mono

Labels
area-Codegen-LLVM-mono area-Codegen-meta-mono
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

[Mono] Enable generating SIMD intrinsics for System.Numerics.Vector on Arm64 fanyang-mono/runtime
1 participant
@fanyang-mono