-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System.Text.Json.SourceGeneration tests failing on netfx x86 #64071
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Hit by #64057 |
Tagging subscribers to this area: @dotnet/area-system-text-json Issue Details
|
I think we should revert until we can stabilize the tests. Side note: this looks like a problem in Roslyn, the parser should never throw. |
It's just 3 tests right? If so we can just disable those 3 for netfx x86. |
That works only if the failure is deterministic. It can be .NET Framework GC hole that hits any test in this assembly. Is the failure deterministic? |
Roslyn's parser is pretty battle tested (as you might guess) -- I think there's a decent chance this could be a runtime bug. Either way, I think revert is a reasonable option here. We found an unanticipated problem with the suite, let's give devs a chance to look this over at their own pace and come back when ready. |
Indeed it is not deterministic. TestResults
//| join kind=inner WorkItems on WorkItemId
| join kind=inner Jobs on JobId
| where Finished >= now(-180d)
| where Result == "Fail"
| where WorkItemFriendlyName == "System.Text.Json.SourceGeneration.Roslyn4.0.Unit.Tests"
| where Message contains "Index"
//| where Type == "System.Composition.Hosting.Core.Tests.ExportDescriptorPromiseTests"
//| where Method == "GetAllocatedBytesForCurrentThread"
//| where Message contains "OSStatus error -50 - failed to generate asymmetric keypair"
| project
//Pipeline = tostring(parse_json(Properties).DefinitionName),
Pipeline_Configuration = tostring(parse_json(Properties).configuration),
// OS = QueueName,
Arch = tostring(parse_json(Properties).architecture),
Test = Type1,
// Result,
Finished,
// Duration,
Method,
// Build = tostring(parse_json(Properties).BuildNumber),
Message
|
The text was updated successfully, but these errors were encountered: