Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RegexNode.ComputeMinLength should do better for some Testref/Testgroup nodes #62723

Closed
stephentoub opened this issue Dec 13, 2021 · 1 comment · Fixed by #63299
Closed

RegexNode.ComputeMinLength should do better for some Testref/Testgroup nodes #62723

stephentoub opened this issue Dec 13, 2021 · 1 comment · Fixed by #63299
Assignees
@stephentoub
Labels
area-System.Text.RegularExpressions tenet-performance Performance related issue
Milestone
7.0.0

Comments

@stephentoub
Copy link
Member

Today these always report a min length of 0. That's correct if there's only a "yes" child branch. But if there's also a "no" child branch, we should instead compute the minimum of both branches.
@stephentoub stephentoub added this to the 7.0.0 milestone Dec 13, 2021
@ghost
Copy link

ghost commented Dec 13, 2021

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

Today these always report a min length of 0. That's correct if there's only a "yes" child branch. But if there's also a "no" child branch, we should instead compute the minimum of both branches.

Author: stephentoub
Assignees: -
Labels:

area-System.Text.RegularExpressions, tenet-performance
Milestone: 7.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Dec 13, 2021
@joperezr joperezr mentioned this issue Dec 14, 2021
Closed
48 tasks
@stephentoub stephentoub self-assigned this Dec 31, 2021
@stephentoub stephentoub mentioned this issue Jan 3, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 3, 2022
@stephentoub stephentoub removed the untriaged New issue has not been triaged by the area owner label Jan 6, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jan 19, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stephentoub stephentoub

Labels
area-System.Text.RegularExpressions tenet-performance Performance related issue
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Improve auto-atomicity for conditionals stephentoub/runtime
1 participant
@stephentoub