Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider rebuilding loop table after loop cloning #62615

Closed
BruceForstall opened this issue Dec 10, 2021 · 2 comments
Closed

Consider rebuilding loop table after loop cloning #62615

BruceForstall opened this issue Dec 10, 2021 · 2 comments
Assignees
@jakobbotsch
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Future

Comments

@BruceForstall
Copy link
Member

BruceForstall commented Dec 10, 2021 •
edited
Loading

Doing this would put the "slow path" cloned loop in the loop table, enabling it for downstream optimization, such as hoisting, and possibly enabling hoisting things common to the slow and fast paths.

It would also let the slow path show more clearly in the JitDumpFg "dot" graph dumps.

category:cq
theme:loop-opt
skill-level:intermediate
cost:medium
impact:small
@BruceForstall BruceForstall added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 10, 2021
@BruceForstall BruceForstall added this to the 7.0.0 milestone Dec 10, 2021
@ghost
Copy link

ghost commented Dec 10, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Doing this would put the "slow path" cloned loop in the loop table, enabling it for downstream optimization, such as hoisting, and possibly enabling hoisting things common to the slow and fast paths.

It would also let the slow path show more clearly in the JitDumpFg "dot" graph dumps.

Author: BruceForstall
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: 7.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Dec 10, 2021
@BruceForstall BruceForstall mentioned this issue Dec 10, 2021
Merged
@jeffschwMSFT jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label Jan 11, 2022
@BruceForstall BruceForstall modified the milestones: 7.0.0, 8.0.0 Aug 4, 2022
@BruceForstall BruceForstall mentioned this issue Jan 5, 2023
Closed
4 tasks
@BruceForstall BruceForstall modified the milestones: 8.0.0, Future Jun 16, 2023
@BruceForstall BruceForstall mentioned this issue Oct 6, 2023
Closed
21 tasks
@jakobbotsch
Copy link
Member

Fixed by PRs listed in #93144 (comment)

@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@jakobbotsch @jeffschwMSFT @BruceForstall