Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICorProfilerCallback11 typo #60965

Closed
ww898 opened this issue Oct 28, 2021 · 2 comments · Fixed by #60999
Closed

ICorProfilerCallback11 typo #60965

ww898 opened this issue Oct 28, 2021 · 2 comments · Fixed by #60999
Labels
area-Diagnostics-coreclr
Milestone
7.0.0

Comments

@ww898
Copy link
Contributor

ww898 commented Oct 28, 2021

Ho @davmason, I found a small typo in the method name ICorProfilerCallback::LoadAsNotficationOnly, but should be LoadAsNotificationOnly. May be it is too late, may be not. Could you please fix it?
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Diagnostics-coreclr untriaged New issue has not been triaged by the area owner labels Oct 28, 2021
@ghost
Copy link

ghost commented Oct 28, 2021

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Ho @davmason, I found a small typo in the method name ICorProfilerCallback::LoadAsNotficationOnly, but should be LoadAsNotificationOnly. May be it is too late, may be not. Could you please fix it?

Author: ww898
Assignees: -
Labels:

area-Diagnostics-coreclr, untriaged
Milestone: -

@tommcdon tommcdon added this to the 7.0.0 milestone Oct 28, 2021
@tommcdon tommcdon removed the untriaged New issue has not been triaged by the area owner label Oct 28, 2021
@davmason
Copy link
Member

It should be fine. It will cause a build break for anyone that has the 6.0 headers and upgrades to one with the change, but it should be easy to figure out and recover

@davmason davmason mentioned this issue Oct 29, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 29, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Nov 2, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Diagnostics-coreclr
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Fix typo in profiler method davmason/runtime
3 participants
@ww898 @davmason @tommcdon