Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] System.Drawing.PrimitivesTest.RectangleTests.RectangleFConversionTest fails on devices #60585

Open
steveisok opened this issue Oct 18, 2021 · 8 comments
Labels
arch-wasm WebAssembly architecture area-System.Drawing os-ios Apple iOS os-tvos Apple tvOS
Milestone

Comments

@steveisok
Copy link
Member

The test fails with:

Assert.Equal() Failure
Expected: {X=-2147483648,Y=2147483647,Width=-2147483648,Height=2147483647}
Actual:   {X=-2147483648,Y=2147483647,Width=0,Height=-1}
Stack trace
   at System.Drawing.PrimitivesTest.RectangleTests.RectangleFConversionTest(Single x, Single y, Single width, Single height)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Drawing untriaged New issue has not been triaged by the area owner labels Oct 18, 2021
@steveisok steveisok added os-ios Apple iOS os-tvos Apple tvOS labels Oct 18, 2021
@steveisok steveisok added this to the 7.0.0 milestone Oct 18, 2021
@jeffschwMSFT jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label Oct 19, 2021
@steveisok steveisok modified the milestones: 7.0.0, Future Jul 27, 2022
@pavelsavara pavelsavara added the arch-wasm WebAssembly architecture label Mar 13, 2023
@ghost
Copy link

ghost commented Mar 13, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

The test fails with:

Assert.Equal() Failure
Expected: {X=-2147483648,Y=2147483647,Width=-2147483648,Height=2147483647}
Actual:   {X=-2147483648,Y=2147483647,Width=0,Height=-1}
Stack trace
   at System.Drawing.PrimitivesTest.RectangleTests.RectangleFConversionTest(Single x, Single y, Single width, Single height)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
Author: steveisok
Assignees: -
Labels:

arch-wasm, area-System.Drawing, os-ios, os-tvos

Milestone: Future

@pavelsavara
Copy link
Member

pavelsavara commented Mar 13, 2023

I see this on wasm now Log

[14:08:33] info: Expected: {X=-2147483648,Y=-2147483648,Width=-2147483648,Height=-2147483648}
[14:08:33] info: Actual:   {X=-2147483648,Y=2147483647,Width=-2147483648,Height=2147483647}
[14:08:33] info:    at System.Reflection.MethodInvoker.Invoke(Object , IntPtr* , BindingFlags )

edit: wasm problem has different signs

@pavelsavara pavelsavara changed the title [iOS/tvOS] System.Drawing.PrimitivesTest.RectangleTests.RectangleFConversionTest fails on devices [mono] System.Drawing.PrimitivesTest.RectangleTests.RectangleFConversionTest fails on devices Mar 13, 2023
@pavelsavara
Copy link
Member

Could this be related to /fp in some way ?
https://learn.microsoft.com/en-us/cpp/build/reference/fp-specify-floating-point-behavior

@pavelsavara
Copy link
Member

Another wasm log

@steveisok
Copy link
Member Author

@pavelsavara you should add wasm to the active issue on the RectangleFConversionTest test.

@steveisok
Copy link
Member Author

What's odd to me is this is hitting wasm now.

@pavelsavara
Copy link
Member

I would rather understand why it started now before we mute it.

@lewing
Copy link
Member

lewing commented Jul 29, 2024

#83394 was opened as well, I'm closing it as a dup of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-System.Drawing os-ios Apple iOS os-tvos Apple tvOS
Projects
None yet
Development

No branches or pull requests

4 participants