Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.IO.Tests.File_ReadWriteAllBytes.ReadAllBytes_NonSeekableFileStream_InWindows failed #60427

Open
Tracked by #64596
runfoapp bot opened this issue Oct 14, 2021 · 6 comments · Fixed by #60471
Open
Tracked by #64596

System.IO.Tests.File_ReadWriteAllBytes.ReadAllBytes_NonSeekableFileStream_InWindows failed #60427

runfoapp bot opened this issue Oct 14, 2021 · 6 comments · Fixed by #60471
Assignees
@adamsitnik
Labels
area-System.IO disabled-test The test is disabled in source code against the issue
Milestone
Future

Comments

@runfoapp
Copy link

runfoapp bot commented Oct 14, 2021 •
edited
Loading

Runfo Tracking Issue: System.IO.Tests.File_ReadWriteAllBytes.ReadAllBytes_NonSeekableFileStream_InWindows failed

Build Definition Kind Run Name

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
0 0 0
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.IO untriaged New issue has not been triaged by the area owner labels Oct 14, 2021
@ghost
Copy link

ghost commented Oct 14, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Runfo Creating Tracking Issue (data being generated)

Author: runfoapp[bot]
Assignees: -
Labels:

area-System.IO, untriaged
Milestone: -

@safern
Copy link
Member

safern commented Oct 14, 2021

I couldn't find an existing issue for this test and just hit it on: #60415

cc: @krwq

@safern safern added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Oct 14, 2021
@safern safern mentioned this issue Oct 14, 2021
Merged
@runfoapp runfoapp bot mentioned this issue Oct 14, 2021
Closed
@ericstj ericstj mentioned this issue Oct 14, 2021
Closed
@ericstj
Copy link
Member

ericstj commented Oct 14, 2021

Looks like this test was just added in #58434 and is failing in many PRs. @lateapexearlyspeed @adamsitnik

@adamsitnik adamsitnik self-assigned this Oct 15, 2021
@lateapexearlyspeed
Copy link
Contributor

lateapexearlyspeed commented Oct 15, 2021 •
edited
Loading

Hi @ericstj Sorry about that.
Hi @adamsitnik seems this WaitForConnectionAsync() in test case takes long time sometimes. I just run this test in my local pc to verify that time-consuming call. And eventually it can return back if remove cancellation token source. Current master code cancels cts after waiting for 50 second. Not sure if we should remove cts (like what we did for unix version test.) ?

@adamsitnik adamsitnik removed the untriaged New issue has not been triaged by the area owner label Oct 15, 2021
@adamsitnik adamsitnik mentioned this issue Oct 15, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 15, 2021
@ericstj
Copy link
Member

ericstj commented Oct 15, 2021

No worries, this happens a lot with tests that have open ended timeouts like this. The scale we run dotnet/runtime tests + load on the machine can cause things to take a lot longer than you'd think possible.

@adamsitnik adamsitnik added this to the 7.0.0 milestone Oct 15, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 15, 2021
@ericstj ericstj reopened this Oct 15, 2021
@ericstj
Copy link
Member

ericstj commented Oct 15, 2021

Reopening to track the disabled test.

@ericstj ericstj added disabled-test The test is disabled in source code against the issue and removed blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' labels Oct 15, 2021
@jozkee jozkee mentioned this issue Oct 15, 2021
Merged
@am11 am11 mentioned this issue Oct 15, 2021
Merged
@jeffhandley jeffhandley mentioned this issue Feb 1, 2022
Closed
50 tasks
@jeffhandley jeffhandley modified the milestones: 7.0.0, Future Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamsitnik adamsitnik

Labels
area-System.IO disabled-test The test is disabled in source code against the issue
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

disable flaky ReadAllBytes_NonSeekableFileStream_InWindows adamsitnik/runtime
5 participants
@jeffhandley @adamsitnik @ericstj @safern @lateapexearlyspeed