System.Linq - Undoc 6.0 APIs

[carlossanlop]

The following APIs were introduced in 6.0 and did not get documented in triple slash. They will need to be manually documented directly in dotnet-api-docs, and must target the net6-rc1 branch. This needs to be done before Tuesday September 14th so we have enough time to generate the IntelliSense package that will be shipped to GA.

Undoc APIs
M:System.Linq.Enumerable.ExceptBy``2(System.Collections.Generic.IEnumerable{``0},System.Collections.Generic.IEnumerable{``1},System.Func{``0,``1})
M:System.Linq.Enumerable.ExceptBy``2(System.Collections.Generic.IEnumerable{``0},System.Collections.Generic.IEnumerable{``1},System.Func{``0,``1},System.Collections.Generic.IEqualityComparer{``1})
M:System.Linq.Queryable.ExceptBy``2(System.Linq.IQueryable{``0},System.Collections.Generic.IEnumerable{``1},System.Linq.Expressions.Expression{System.Func{``0,``1}})
M:System.Linq.Queryable.ExceptBy``2(System.Linq.IQueryable{``0},System.Collections.Generic.IEnumerable{``1},System.Linq.Expressions.Expression{System.Func{``0,``1}},System.Collections.Generic.IEqualityComparer{``1})

[ghost]

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The following APIs were introduced in 6.0 and did not get documented in triple slash. They will need to be manually documented directly in dotnet-api-docs, and must target the net6-rc1 branch. This needs to be done before Tuesday September 14th so we have enough time to generate the IntelliSense package that will be shipped to GA.

Undoc APIs
M:System.Linq.Enumerable.ExceptBy``2(System.Collections.Generic.IEnumerable{``0},System.Collections.Generic.IEnumerable{``1},System.Func{``0,``1})
M:System.Linq.Enumerable.ExceptBy``2(System.Collections.Generic.IEnumerable{``0},System.Collections.Generic.IEnumerable{``1},System.Func{``0,``1},System.Collections.Generic.IEqualityComparer{``1})
M:System.Linq.Queryable.ExceptBy``2(System.Linq.IQueryable{``0},System.Collections.Generic.IEnumerable{``1},System.Linq.Expressions.Expression{System.Func{``0,``1}})
M:System.Linq.Queryable.ExceptBy``2(System.Linq.IQueryable{``0},System.Collections.Generic.IEnumerable{``1},System.Linq.Expressions.Expression{System.Func{``0,``1}},System.Collections.Generic.IEqualityComparer{``1})

Author:	carlossanlop
Assignees:	eiriktsarpalis, layomia
Labels:	area-System.Linq
Milestone:	6.0.0

[eiriktsarpalis]

must target the net6-rc1 branch

Need some clarification here. Assuming we need to port these to main first then backport to net6-rc1? cc @gewarren

[gewarren]

must target the net6-rc1 branch

Need some clarification here. Assuming we need to port these to main first then backport to net6-rc1? cc @gewarren

I'm going to let @carlossanlop answer that. I wasn't aware till late last week that we were going to create PRs to the RC1 branch. I thought the RC1 branch was just to generate the report.

[IEvangelist]

It appears that there are actually more APIs from System.Linq that are missing triple slash comments, I shared my findings here.

#58756

• Chunk
• ExceptBy
• ElementAt(..., Index)
• ElementAtOrDefault(..., Index)
• DistinctBy
• LastOrDefault(..., defaultValue)
• MaxBy
• MinBy
• SingleOrDefault(..., defaultValue)
• UnionBy
• Zip

[eiriktsarpalis]

@IEvangelist this concerns missing docs in dotnet-api-docs. Linq triple-slash docs in dotnet/runtime are largely missing, but this should not be a blocker from a 6.0 perspective. FWIW an attempt was made to backport docs to triple-slash in #51140 but that was aborted due to unresolved issues in the backporting process.

[carlossanlop]

I'm going to let @carlossanlop answer that. I wasn't aware till late last week that we were going to create PRs to the RC1 branch. I thought the RC1 branch was just to generate the report.

@gewarren @eiriktsarpalis if your APIs were merged in an early preview, then it's ok to have them in main.

The main reason why I asked for the net6-rc1 is because main did not contain the APIs that were introduced last minute. So I wanted to make sure we have a branch with the latest API structure available.

[eiriktsarpalis]

And presumably any net6-rc1 change would be merged independently back in to main?

[gewarren]

And presumably any net6-rc1 change would be merged independently back in to main?

I don't think we've been doing that. The net6-rc1 branch will be merged to main on 9/14.

[eiriktsarpalis]

Fixed by dotnet/dotnet-api-docs#7154