-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "requestId" arguments from HTTP tests loopback server API #58239
Comments
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThis is used very infrequently, and doesn't actually seem to be necessary in the places where it is used. It also is weirdly inconsistent across HTTP/1.1/2/3. In general, it seems like non-version-specific tests should never need this, and we should just remove it.
|
Triage: This should be fairly simple, marking as up-for-grabs. Good for learning more about HTTP protocol. |
Hi @karelz , @geoffkizer . |
kinldy eloborate the issue |
@AnudeepGunukula I think the idea was to remove the argument -- which means, incl. inherited classes. Making it compile should be fairly straightforward, shouldn't it? FYI: It would be best to keep code question on the PR. |
This is used very infrequently, and doesn't actually seem to be necessary in the places where it is used.
It also is weirdly inconsistent across HTTP/1.1/2/3.
In general, it seems like non-version-specific tests should never need this, and we should just remove it.
The text was updated successfully, but these errors were encountered: