Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "requestId" arguments from HTTP tests loopback server API #58239

Closed
geoffkizer opened this issue Aug 27, 2021 · 5 comments · Fixed by #58678
Closed

Remove "requestId" arguments from HTTP tests loopback server API #58239

geoffkizer opened this issue Aug 27, 2021 · 5 comments · Fixed by #58678
Labels
area-System.Net.Http help wanted [up-for-grabs] Good issue for external contributors test-enhancement Improvements of test source code
Milestone

Comments

@geoffkizer
Copy link
Contributor

This is used very infrequently, and doesn't actually seem to be necessary in the places where it is used.

It also is weirdly inconsistent across HTTP/1.1/2/3.

In general, it seems like non-version-specific tests should never need this, and we should just remove it.

@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Net.Http untriaged New issue has not been triaged by the area owner labels Aug 27, 2021
@ghost
Copy link

ghost commented Aug 27, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This is used very infrequently, and doesn't actually seem to be necessary in the places where it is used.

It also is weirdly inconsistent across HTTP/1.1/2/3.

In general, it seems like non-version-specific tests should never need this, and we should just remove it.

Author: geoffkizer
Assignees: -
Labels:

area-System.Net.Http, untriaged

Milestone: -

@geoffkizer geoffkizer added the test-enhancement Improvements of test source code label Aug 27, 2021
@karelz karelz removed the untriaged New issue has not been triaged by the area owner label Sep 2, 2021
@karelz karelz added this to the 7.0.0 milestone Sep 2, 2021
@karelz karelz added the help wanted [up-for-grabs] Good issue for external contributors label Sep 2, 2021
@karelz
Copy link
Member

karelz commented Sep 2, 2021

Triage: This should be fairly simple, marking as up-for-grabs. Good for learning more about HTTP protocol.

@AnudeepGunukula
Copy link
Contributor

Hi @karelz , @geoffkizer .
i had made a pr that will close this issue.
kindly review it and please let me know the changes if needed.

@AnudeepGunukula
Copy link
Contributor

kinldy eloborate the issue
i removed the requestId argument from loopbackserver.cs and then
also removed argument from the abstract methods in genericloopbackserver.cs
which further causing errors in its implemented methods in http2loopbackconnection.cs and http3loopbackconnection.cs
kindly help me here should i continue removing requestId from those methods also.

@karelz
Copy link
Member

karelz commented Sep 7, 2021

@AnudeepGunukula I think the idea was to remove the argument -- which means, incl. inherited classes. Making it compile should be fairly straightforward, shouldn't it?

FYI: It would be best to keep code question on the PR.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Http help wanted [up-for-grabs] Good issue for external contributors test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants