Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyTabAttribute.Equals(PropertyTabAttribute other) should likely accept null #55178

Closed
krwq opened this issue Jul 5, 2021 · 1 comment · Fixed by #85896
Closed

PropertyTabAttribute.Equals(PropertyTabAttribute other) should likely accept null #55178

krwq opened this issue Jul 5, 2021 · 1 comment · Fixed by #85896

Comments

@krwq
Copy link
Member

krwq commented Jul 5, 2021

Found during adding nullable annotations to TypeConverter (#54961).

Most likely the signature for this method should look like:

public bool Equals([NotNullWhen(true)] PropertyTabAttribute? other)

but currently it will throw NRE as it accesses members without any null checks

@ghost
Copy link

ghost commented Jul 5, 2021

Tagging subscribers to this area: @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

Found during adding nullable annotations to TypeConverter (#54961).

Most likely the signature for this method should look like:

public bool Equals([NotNullWhen(true)] PropertyTabAttribute? other)

but currently it will throw NRE as it accesses members without any null checks

Author: krwq
Assignees: -
Labels:

area-System.ComponentModel

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jul 5, 2021
@safern safern added this to the 7.0.0 milestone Jul 22, 2021
@safern safern removed the untriaged New issue has not been triaged by the area owner label Jul 22, 2021
@eerhardt eerhardt modified the milestones: 7.0.0, Future Jul 19, 2022
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 7, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 9, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants