Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ValueStringBuilder public #54535

Closed
jogibear9988 opened this issue Jun 22, 2021 · 4 comments
Closed

Make ValueStringBuilder public #54535

jogibear9988 opened this issue Jun 22, 2021 · 4 comments
Labels
untriaged New issue has not been triaged by the area owner

Comments

@jogibear9988
Copy link

Why is this internal: https://github.com/dotnet/runtime/blob/main/src/libraries/Common/src/System/Text/ValueStringBuilder.cs

As other Librarys already try to copy this (AngleSharp/AngleSharp#981), I suggest to make it public.
see also: #25587
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 22, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@huoyaoyuan
Copy link
Member

Why is this internal

Because it's design isn't mature and using it requires explicit attention. I have found potential misuse even in the runtime repo.

@turbedi
Copy link

turbedi commented Jun 22, 2021

Duplicate issue

@stephentoub
Copy link
Member

Dup of #25587

@ghost ghost locked as resolved and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jogibear9988 @stephentoub @turbedi @huoyaoyuan