Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MONO][Interp] JIT/IL_Conformance/* tests failed return the correct return code with interpreter #54376

Closed
fanyang-mono opened this issue Jun 17, 2021 · 2 comments
Closed

[MONO][Interp] JIT/IL_Conformance/* tests failed return the correct return code with interpreter #54376

fanyang-mono opened this issue Jun 17, 2021 · 2 comments
Labels
area-Codegen-Interpreter-mono
Milestone
7.0.0

Comments

@fanyang-mono
Copy link
Member

Failed tests list:

  • JIT/IL_Conformance/Old/Base/ckfinite/ckfinite.sh
  • JIT/IL_Conformance/Old/Conformance_Base/add_r4/add_r4.sh
  • JIT/IL_Conformance/Old/Conformance_Base/ckfinite_r4/ckfinite_r4.sh
  • JIT/IL_Conformance/Old/Conformance_Base/div_r4/div_r4.sh
  • JIT/IL_Conformance/Old/Conformance_Base/ldc_ckfinite_r4/ldc_ckfinite_r4.sh
  • JIT/IL_Conformance/Old/Conformance_Base/mul_r4/mul_r4.sh
  • JIT/IL_Conformance/Old/Conformance_Base/neg_r4/neg_r4.sh
  • JIT/IL_Conformance/Old/Conformance_Base/rem_r4/rem_r4.sh
  • JIT/IL_Conformance/Old/Conformance_Base/sub_r4/sub_r4.sh

Full log

Error message:

06-17 16:46:12.048  7416  7434 I DOTNET  : MonoRunner initialize,, entryPointLibName=ckfinite.dll
      06-17 16:46:12.048  7416  7434 D DOTNET  : file_path: /data/user/0/net.dot.JIT_IL_Conformance/files/runtimeconfig.bin
      06-17 16:46:12.048  7416  7434 D DOTNET  : Interp Enabled
      06-17 16:46:12.050  7416  7434 D DOTNET  : assembly_preload_hook: System.Private.CoreLib (null) /data/user/0/net.dot.JIT_IL_Conformance/files
      06-17 16:46:12.086  7416  7434 D DOTNET  : assembly_preload_hook: ckfinite.dll (null) /data/user/0/net.dot.JIT_IL_Conformance/files
      06-17 16:46:12.086  7416  7434 D DOTNET  : Executable: ckfinite.dll
      06-17 16:46:12.086  7416  7434 D DOTNET  : assembly_preload_hook: mscorlib  /data/user/0/net.dot.JIT_IL_Conformance/files
      06-17 16:46:12.087  7416  7434 D DOTNET  : Exit code: 0.
      06-17 16:46:12.100  7416  7434 I DOTNET  : MonoRunner finished, return-code=0
      06-17 16:46:12.102  1797  3117 I ActivityManager: Force stopping net.dot.JIT_IL_Conformance appid=10119 user=0: finished inst
      06-17 16:46:12.102  1797  3117 I ActivityManager: Killing 7416:net.dot.JIT_IL_Conformance/u0a119 (adj 0): stop net.dot.JIT_IL_Conformance
      06-17 16:46:12.102  1797  7393 W Binder  : Outgoing transactions from this process must be FLAG_ONEWAY
      06-17 16:46:12.102  1797  7393 W Binder  : java.lang.Throwable
      06-17 16:46:12.102  1797  7393 W Binder  : 	at android.os.BinderProxy.transact(BinderProxy.java:480)
      06-17 16:46:12.102  1797  7393 W Binder  : 	at android.app.IInstrumentationWatcher$Stub$Proxy.instrumentationFinished(IInstrumentationWatcher.java:205)
      06-17 16:46:12.102  1797  7393 W Binder  : 	at com.android.server.am.InstrumentationReporter$MyThread.run(InstrumentationReporter.java:86)
      06-17 16:46:12.111  7406  7406 D AndroidRuntime: Shutting down VM
      06-17 16:46:12.115  1544  1544 I Zygote  : Process 7416 exited due to signal 9 (Killed)
      06-17 16:46:12.130  1797  7393 I ActivityManager: Failure reporting to instrumentation watcher: comp=ComponentInfo{net.dot.JIT_IL_Conformance/net.dot.MonoRunner} results=Bundle[mParcelledData.dataSize=40]
      06-17 16:46:12.148  1797  1826 I libprocessgroup: Successfully killed process cgroup uid 10119 pid 7416 in 45ms
@ghost
Copy link

ghost commented Jun 17, 2021

Tagging subscribers to this area: @BrzVlad
See info in area-owners.md if you want to be subscribed.

Issue Details

Failed tests list:

  • JIT/IL_Conformance/Old/Base/ckfinite/ckfinite.sh
  • JIT/IL_Conformance/Old/Conformance_Base/add_r4/add_r4.sh
  • JIT/IL_Conformance/Old/Conformance_Base/ckfinite_r4/ckfinite_r4.sh
  • JIT/IL_Conformance/Old/Conformance_Base/div_r4/div_r4.sh
  • JIT/IL_Conformance/Old/Conformance_Base/ldc_ckfinite_r4/ldc_ckfinite_r4.sh
  • JIT/IL_Conformance/Old/Conformance_Base/mul_r4/mul_r4.sh
  • JIT/IL_Conformance/Old/Conformance_Base/neg_r4/neg_r4.sh
  • JIT/IL_Conformance/Old/Conformance_Base/rem_r4/rem_r4.sh
  • JIT/IL_Conformance/Old/Conformance_Base/sub_r4/sub_r4.sh

Full log

Error message:

06-17 16:46:12.048  7416  7434 I DOTNET  : MonoRunner initialize,, entryPointLibName=ckfinite.dll
      06-17 16:46:12.048  7416  7434 D DOTNET  : file_path: /data/user/0/net.dot.JIT_IL_Conformance/files/runtimeconfig.bin
      06-17 16:46:12.048  7416  7434 D DOTNET  : Interp Enabled
      06-17 16:46:12.050  7416  7434 D DOTNET  : assembly_preload_hook: System.Private.CoreLib (null) /data/user/0/net.dot.JIT_IL_Conformance/files
      06-17 16:46:12.086  7416  7434 D DOTNET  : assembly_preload_hook: ckfinite.dll (null) /data/user/0/net.dot.JIT_IL_Conformance/files
      06-17 16:46:12.086  7416  7434 D DOTNET  : Executable: ckfinite.dll
      06-17 16:46:12.086  7416  7434 D DOTNET  : assembly_preload_hook: mscorlib  /data/user/0/net.dot.JIT_IL_Conformance/files
      06-17 16:46:12.087  7416  7434 D DOTNET  : Exit code: 0.
      06-17 16:46:12.100  7416  7434 I DOTNET  : MonoRunner finished, return-code=0
      06-17 16:46:12.102  1797  3117 I ActivityManager: Force stopping net.dot.JIT_IL_Conformance appid=10119 user=0: finished inst
      06-17 16:46:12.102  1797  3117 I ActivityManager: Killing 7416:net.dot.JIT_IL_Conformance/u0a119 (adj 0): stop net.dot.JIT_IL_Conformance
      06-17 16:46:12.102  1797  7393 W Binder  : Outgoing transactions from this process must be FLAG_ONEWAY
      06-17 16:46:12.102  1797  7393 W Binder  : java.lang.Throwable
      06-17 16:46:12.102  1797  7393 W Binder  : 	at android.os.BinderProxy.transact(BinderProxy.java:480)
      06-17 16:46:12.102  1797  7393 W Binder  : 	at android.app.IInstrumentationWatcher$Stub$Proxy.instrumentationFinished(IInstrumentationWatcher.java:205)
      06-17 16:46:12.102  1797  7393 W Binder  : 	at com.android.server.am.InstrumentationReporter$MyThread.run(InstrumentationReporter.java:86)
      06-17 16:46:12.111  7406  7406 D AndroidRuntime: Shutting down VM
      06-17 16:46:12.115  1544  1544 I Zygote  : Process 7416 exited due to signal 9 (Killed)
      06-17 16:46:12.130  1797  7393 I ActivityManager: Failure reporting to instrumentation watcher: comp=ComponentInfo{net.dot.JIT_IL_Conformance/net.dot.MonoRunner} results=Bundle[mParcelledData.dataSize=40]
      06-17 16:46:12.148  1797  1826 I libprocessgroup: Successfully killed process cgroup uid 10119 pid 7416 in 45ms
Author: fanyang-mono
Assignees: -
Labels:

area-Codegen-Interpreter-mono, os-android
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 17, 2021
@fanyang-mono fanyang-mono mentioned this issue Jun 17, 2021
Open
26 tasks
@fanyang-mono fanyang-mono changed the title [MONO][Android][Interp] JIT/IL_Conformance/* tests failed return the correct return code on Android x64 with interpreter [MONO][Interp] JIT/IL_Conformance/* tests failed return the correct return code with interpreter Jun 18, 2021
@SamMonoRT SamMonoRT removed the untriaged New issue has not been triaged by the area owner label Jun 21, 2021
@SamMonoRT SamMonoRT added this to the 7.0.0 milestone Jun 21, 2021
@am11
Copy link
Member

am11 commented Nov 1, 2021

Not sure if call to std lib's isinfinity() the right thing mono is currently using (for interpreter as well as jit?), but going by coreclr/jit, ckfinite emulation in C is essentially: https://godbolt.org/z/vxMYrvb8d. "exponent bits all-ON" check takes care of both; isInfinity and isNaN.
cc @lambdageek

@BrzVlad BrzVlad closed this as completed Mar 26, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Codegen-Interpreter-mono
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
4 participants
@am11 @BrzVlad @SamMonoRT @fanyang-mono