Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Blazor Wasm - Size Regression in System.Net.Http.Json.dll #51636

Closed
DrewScoggins opened this issue Apr 21, 2021 · 8 comments
Closed

[Perf] Blazor Wasm - Size Regression in System.Net.Http.Json.dll #51636

DrewScoggins opened this issue Apr 21, 2021 · 8 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-System.Text.Json size-reduction Issues impacting final app size primary for size sensitive workloads
Milestone

Comments

@DrewScoggins
Copy link
Member

Run Information

Architecture x64
OS ubuntu 18.04
Baseline 466deef23436fd8705db5ebaa6d719c3fa153766
Compare 8c3180d932146b1a76600601c03082c6a81e1a53
Diff Diff

Regressions in SOD - New Blazor Template - Publish

Benchmark Baseline Test Test/Base Test Quality Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Net.Http.Json.dll.gz 4.65 KB 4.93 KB 1.06 0.00
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Linq.dll.br 9.56 KB 9.65 KB 1.01 0.00
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Net.Http.Json.dll 10.50 KB 11.00 KB 1.05 0.00
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Net.Http.Json.dll.br 4.17 KB 4.42 KB 1.06 0.00

graph
graph
graph
graph
Historical Data in Reporting System

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@DrewScoggins DrewScoggins added arch-wasm WebAssembly architecture size-reduction Issues impacting final app size primary for size sensitive workloads labels Apr 21, 2021
@ghost
Copy link

ghost commented Apr 21, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture x64
OS ubuntu 18.04
Baseline 466deef23436fd8705db5ebaa6d719c3fa153766
Compare 8c3180d932146b1a76600601c03082c6a81e1a53
Diff Diff

Regressions in SOD - New Blazor Template - Publish

Benchmark Baseline Test Test/Base Test Quality Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Net.Http.Json.dll.gz 4.65 KB 4.93 KB 1.06 0.00
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Linq.dll.br 9.56 KB 9.65 KB 1.01 0.00
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Net.Http.Json.dll 10.50 KB 11.00 KB 1.05 0.00
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Net.Http.Json.dll.br 4.17 KB 4.42 KB 1.06 0.00

graph
graph
graph
graph
Historical Data in Reporting System

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: DrewScoggins
Assignees: -
Labels:

arch-wasm, size-reduction

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 21, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@DrewScoggins
Copy link
Member Author

@SamMonoRT

@SamMonoRT
Copy link
Member

cc @CoffeeFlux @eerhardt @layomia

@eerhardt
Copy link
Member

Looks to be #51528. Why these new APIs aren't getting trimmed, I don't know.

@ghost
Copy link

ghost commented Apr 22, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture x64
OS ubuntu 18.04
Baseline 466deef23436fd8705db5ebaa6d719c3fa153766
Compare 8c3180d932146b1a76600601c03082c6a81e1a53
Diff Diff

Regressions in SOD - New Blazor Template - Publish

Benchmark Baseline Test Test/Base Test Quality Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Net.Http.Json.dll.gz 4.65 KB 4.93 KB 1.06 0.00
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Linq.dll.br 9.56 KB 9.65 KB 1.01 0.00
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Net.Http.Json.dll 10.50 KB 11.00 KB 1.05 0.00
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Net.Http.Json.dll.br 4.17 KB 4.42 KB 1.06 0.00

graph
graph
graph
graph
Historical Data in Reporting System

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: DrewScoggins
Assignees: -
Labels:

arch-wasm, area-System.Text.Json, size-reduction, untriaged

Milestone: -

@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Jun 17, 2021
@lewing lewing added this to the 6.0.0 milestone Jun 17, 2021
@eiriktsarpalis
Copy link
Member

@DrewScoggins how can I get more recent readings on individual file sizes? Links like this one seem to only report aggregate sizes.

@eiriktsarpalis eiriktsarpalis self-assigned this Aug 2, 2021
@steveharter
Copy link
Member

I can't seem to repro. When I create a project that use other methods in S.N.H.Json.dll and publish\trim it, the new extensions (e.g.GetFromJsonAsync(JsonSerializerContext)) are not present in the HttpClientJsonExtensions static class.

Closing until we have a repro or more information on how to create a repro.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Text.Json size-reduction Issues impacting final app size primary for size sensitive workloads
Projects
None yet
Development

No branches or pull requests

7 participants