Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Full GC ends up in loop in get_next_size #40214

Closed
lewing opened this issue Jul 31, 2020 · 4 comments
Closed

[wasm] Full GC ends up in loop in get_next_size #40214

lewing opened this issue Jul 31, 2020 · 4 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-GC-mono
Milestone

Comments

@lewing
Copy link
Member

lewing commented Jul 31, 2020

Description

Blazor benchmarks seem to be triggering an infinite loop in mono\metadata\mempool.c:

static guint
get_next_size (MonoMemPool *pool, int size)
{
       int target = pool->next? pool->next->size: pool->size;
       size += SIZEOF_MEM_POOL;
       /* increase the size */
       target += target / 2;
       while (target < size) {
              target += target / 2;
       }
       if (target > MONO_MEMPOOL_PAGESIZE && size <= MONO_MEMPOOL_PAGESIZE)
              target = MONO_MEMPOOL_PAGESIZE;
       return target;
}

The problem is that for some reason, the value of ‘target’ has become zero. Disabling the full gc seems to avoid the issue.

cc @pranavkm @paolosevMSFT

@lewing lewing added arch-wasm WebAssembly architecture area-GC-mono labels Jul 31, 2020
@lewing lewing added this to the 5.0.0 milestone Jul 31, 2020
@ghost
Copy link

ghost commented Jul 31, 2020

Tagging subscribers to this area: @BrzVlad
See info in area-owners.md if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jul 31, 2020
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Jul 31, 2020
@lewing lewing assigned kg Aug 3, 2020
@BrzVlad BrzVlad assigned BrzVlad and unassigned vargaz and kg Aug 4, 2020
@SamMonoRT SamMonoRT modified the milestones: 5.0.0, 6.0.0 Aug 13, 2020
@SamMonoRT
Copy link
Member

We'll ship with full GC disabled just like the prior release. The tests will have GC enabled to flush out such issues. Moving to 6.0.0 Milestone.

@SamMonoRT
Copy link
Member

@lewing - is this still an issue with GC enabled now ?

@lewing
Copy link
Member Author

lewing commented Jun 24, 2021

gc is enabled. closing

@lewing lewing closed this as completed Jun 24, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-GC-mono
Projects
None yet
Development

No branches or pull requests

6 participants