-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WinHttpHandler can set arbitrary options on native WinHTTP #39210
Comments
Tagging subscribers to this area: @dotnet/ncl |
This doesn't seem unreasonable, though I'd like to see some interest here before moving forward. |
@alnikola can you comment on what issues you are seeing? I was looking at adopting this for .net framework for calling azure functions. I don't want to stumble across a ton of issues. |
We have seen the interest. Last time we looked at it, there was difficulty in global vs. per session/handle settings - the latter is something we do not expose today. |
There is one issue that session and request handlers are created only when the first request is sent, meaning they cannot be set via regular properties. However, it seems quite easy to add callbacks to be invoked when session is created or on each requests where the user can access these handlers directly. |
@antonfirsov Please, take a look. |
We had a few discussions within the team realizing this feature isn't as trivial as it initially seemed. TLDR: Currently we don't have a good way to validate an API for this feature. More then the half of the options are bound to the request handle, and many of them have to be set and/or queried at arbitrary points of the request lifecycle. In #42592 I'm suggesting a solution to achieve this, but considering the fact that: (1) As part of the analysis I did a review on existing WinHttp options exposed through WinHttp handler properties in historical context:
Judging only by this data it is questionable whetherer this is indeed a critical feature. If there are not enough new user requests justifying the non-trivial design work we need to do to finish this feature, we'll probably put this on hold. |
Given the amount of work this would take, I think we should hold off doing anything here until we have clear customer requests for this. |
In the past and now again we are seeing multiple instances of the same problem - callers of the managed HttpClient using the WinHttpHandler for HTTP/2 are facing a problem already solved in the native WinHTTP. Those solutions are enabled and configured through WinHTTP session and request options, however the users don't have access to them because the WinHttpHandler doesn't expose the corresponding API. To solve this class of problems once and for all it's proposed to add a generic passthrough mechanism so the callers can query and set options on the WinHTTP session and request handles.
The text was updated successfully, but these errors were encountered: