Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "tools-local" folder to "tools" #39007

Closed
safern opened this issue Jul 9, 2020 · 4 comments
Closed

Rename "tools-local" folder to "tools" #39007

safern opened this issue Jul 9, 2020 · 4 comments

Comments

@safern
Copy link
Member

safern commented Jul 9, 2020

We have some local MSBuild tasks that don't come from arcade and are part of the tools-local folder.

This naming convention came from the repo consolidation as this was how core-setup named it. The reason for that name, is because back in the days when we used buildtools, buildtools would restore the tools and would put them in a folder called "tools" in the root of the repo, so to avoid that clash, we named it "tools-local".

Nowadays everything that comes from arcade is under eng/common so I think to avoid confusion, we should rename it to tools since it is implicitly "local"

cc: @jkotas @stephentoub @danmosemsft @dotnet/runtime-infrastructure

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jul 9, 2020
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@safern safern added area-Infrastructure and removed untriaged New issue has not been triaged by the area owner labels Jul 9, 2020
@ghost
Copy link

ghost commented Jul 9, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@safern safern added this to the 5.0.0 milestone Jul 9, 2020
@ViktorHofer
Copy link
Member

Please see #36519 which talks about removing the tools-local folder entirely.

@safern
Copy link
Member Author

safern commented Jul 9, 2020

Dang it, I should've searched for that 😄. Closing as a dupe then.

@safern safern closed this as completed Jul 9, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants