Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark System.Diagnostics.DiagnosticsEventSource.TransformSpec.PropertySpec.PropertyFetch.FetcherForProperty as unsafe for linker-trimming #38404

Closed
layomia opened this issue Jun 25, 2020 · 4 comments
Closed

Mark System.Diagnostics.DiagnosticsEventSource.TransformSpec.PropertySpec.PropertyFetch.FetcherForProperty as unsafe for linker-trimming #38404

layomia opened this issue Jun 25, 2020 · 4 comments
Assignees
@eerhardt
Labels
area-System.Diagnostics enhancement Product code improvement that does NOT require public API changes/additions linkable-framework Issues associated with delivering a linker friendly framework
Milestone
6.0.0

Comments

@layomia
Copy link
Contributor

layomia commented Jun 25, 2020

See discussion here: #38216 (comment)

runtime/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs

Line 898 in afc9f65

public static PropertyFetch FetcherForProperty(Type? type, string propertyName)

@layomia layomia added the linkable-framework Issues associated with delivering a linker friendly framework label Jun 25, 2020
@layomia layomia added this to the 5.0.0 milestone Jun 25, 2020
@layomia layomia self-assigned this Jun 25, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jun 25, 2020
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@layomia layomia mentioned this issue Jun 25, 2020
Merged
@ghost
Copy link

ghost commented Jun 25, 2020

Tagging subscribers to this area: @tommcdon, @krwq
Notify danmosemsft if you want to be subscribed.

@tommcdon tommcdon removed the untriaged New issue has not been triaged by the area owner label Jun 29, 2020
@eerhardt
Copy link
Member

This isn't necessary for 5.0, there are a lot of APIs that are unsafe that aren't being marked. Moving to 6.0.

@eerhardt eerhardt modified the milestones: 5.0.0, 6.0.0 Jul 30, 2020
@josalem josalem added the enhancement Product code improvement that does NOT require public API changes/additions label Nov 7, 2020
@eerhardt eerhardt assigned eerhardt and unassigned layomia Jan 26, 2021
@eerhardt
Copy link
Member

This was addressed in #50265.

@ghost ghost locked as resolved and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eerhardt eerhardt

Labels
area-System.Diagnostics enhancement Product code improvement that does NOT require public API changes/additions linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
5 participants
@eerhardt @layomia @tommcdon @josalem @Dotnet-GitSync-Bot