Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ICU App-Local tests #35930

Closed
safern opened this issue May 7, 2020 · 7 comments
Closed

Add ICU App-Local tests #35930

safern opened this issue May 7, 2020 · 7 comments
Assignees
@safern
Labels
area-System.Globalization test-enhancement Improvements of test source code
Milestone
Future

Comments

@safern
Copy link
Member

safern commented May 7, 2020

We need to add tests by building a NuGet package in runtime-assets containing ICU and validating that everything works fine.
@safern safern self-assigned this May 7, 2020
@ghost
Copy link

ghost commented May 7, 2020

Tagging subscribers to this area: @tarekgh, @safern, @krwq
Notify danmosemsft if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label May 7, 2020
@tarekgh tarekgh added test-enhancement Improvements of test source code and removed untriaged New issue has not been triaged by the area owner labels May 7, 2020
@tarekgh tarekgh added this to the 5.0 milestone May 7, 2020
@tarekgh
Copy link
Member

tarekgh commented May 7, 2020

#35383
#826

@mjsabby
Copy link
Contributor

mjsabby commented May 29, 2020

Any updates here?

Also it would be good to ensure that vcpkg built ICU libraries can be consumed by this functionality.

@safern
Copy link
Member Author

safern commented May 29, 2020 •
edited
Loading

Not yet @mjsabby — it is the next item on my priority list. Will be working on this next week.

Also it would be good to ensure that vcpkg built ICU libraries can be consumed by this functionality.

Which are those ICU libraries? How are those consumed?

@safern
Copy link
Member Author

safern commented Sep 2, 2020

@tarekgh ill try to get this in the next days if I can't get it on Friday I'll re-adjust to 6.0.0

@safern safern modified the milestones: 5.0.0, 6.0.0 Sep 4, 2020
@tarekgh tarekgh modified the milestones: 6.0.0, 7.0.0 Jul 19, 2021
@tarekgh
Copy link
Member

tarekgh commented Jul 19, 2021

@safern I moved this to 7.0. let me know if you think otherwise.

This was referenced Aug 23, 2021
Merged
Merged
@tarekgh tarekgh modified the milestones: 7.0.0, Future Jul 11, 2022
@tarekgh
Copy link
Member

tarekgh commented Jul 11, 2022

Closing this. we can revisit if we need to do that in the future.

@tarekgh tarekgh closed this as completed Jul 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@safern safern

Labels
area-System.Globalization test-enhancement Improvements of test source code
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@mjsabby @tarekgh @safern @Dotnet-GitSync-Bot