-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Marshal API test coverage for generics marshalling #35193
Comments
Moving to 6.0 as test debt we need to address. |
I've validated that we already have coverage for As mentioned in the original issue, we don't have tests for |
Does this include versions of runtime/src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.cs Lines 107 to 125 in ae64899
runtime/src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.cs Lines 605 to 613 in ae64899
|
It looks like we also don't block those. I'll add some testing for those cases 😢 |
#103 added support for marshalling generics, but we don't seem to have test coverage for the Marshal APIs with this:
E.g. Marshal.OffsetOf already worked on desktop CLR because the runtime didn't do a good job of blocking it (and it also raises a question as to whether the code paths this is taking are quite different that made it so that blocking didn't take place). We don't have tests that the returned numbers are actually good.
We might as well throw in a test for marshalling as UnmanagedType.AsAny because I'm sure WinForms is keen to use that (
/snark
).I'm making this a .NET 5 issue since this is a new feature.
The text was updated successfully, but these errors were encountered: