-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft.Extensions.Caching.Memory.Test hitting FailFast in CI #34952
Comments
Tagging subscribers to this area: @ViktorHofer |
@jaredpar thanks for reporting. When opening such issues can you please check if the bot sets the right label so that area-owners are notified? |
FYI: I don't think that is the right label. The failure is due to an assertion in |
Here is the full list of failures Common.Tests Work Item 12 |
Got it, still this definitely isn't area-Infrastructure. |
The Mono test issues look like what should be fixed by #34951 but since I see some CoreCLR runs in your list those might be different issues? |
Sure I can fix the label. But next time you need to give me more than two minutes to do so. Given that CI is completely busted I had attached a higher priority at sending an alert that we needed to fix that. How did this change get through the PR process without triggering a failure? Given that it took down all of CI I think it's important we understand what this gap is. |
It did show on the PR but was still merged. |
What was the source PR? |
@jaredpar this was meant as constructive feedback. I didn't mean to offend you in any way. |
@ViktorHofer no worries. I just got caught up digging into the tests right after I submitted. The failure assert rung a bell and I ran off in that area. |
The Mono issue was fixed so we can probably close this one. |
Console Log Summary
Builds
Configurations
Helix Logs
The text was updated successfully, but these errors were encountered: