Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime-live-build failing on all PRs #31985

Closed
stephentoub opened this issue Feb 9, 2020 · 0 comments · Fixed by #31999
Closed

runtime-live-build failing on all PRs #31985

stephentoub opened this issue Feb 9, 2020 · 0 comments · Fixed by #31999
Labels
area-Infrastructure blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
Milestone
5.0.0

Comments

@stephentoub
Copy link
Member

stephentoub commented Feb 9, 2020 •
edited
Loading

From @safern:
"I believe it’s the cmake error."
"We've got to pass -warnAsError:0 on the Windows legs"
"Linux is not affected"
https://github.com/dotnet/runtime/blob/master/eng/pipelines/common/global-build-job.yml#L40
"You just need to define an intermediate variable and set it to empty and then to the arg if platform is Windows_NT. Because the syntax is different for bash and PS and this only fails on Windows"

cc: @ViktorHofer, @jkoritzinsky, @trylek
@stephentoub stephentoub added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' area-Infrastructure labels Feb 9, 2020
@stephentoub stephentoub added this to the 5.0 milestone Feb 9, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Feb 9, 2020
@stephentoub stephentoub removed the untriaged New issue has not been triaged by the area owner label Feb 9, 2020
@EgorBo EgorBo mentioned this issue Feb 9, 2020
Closed
@trylek trylek mentioned this issue Feb 9, 2020
Merged
@ghost ghost added the will_lock_this label Dec 6, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Infrastructure blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Fix for runtime-live-build break per Santi's suggestion trylek/runtime
2 participants
@stephentoub @Dotnet-GitSync-Bot