Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance tests for JsonNode and related types #30865

Closed
ahsonkhan opened this issue Sep 16, 2019 · 2 comments
Closed

Add performance tests for JsonNode and related types #30865

ahsonkhan opened this issue Sep 16, 2019 · 2 comments
Assignees
Labels
area-System.Text.Json backlog-cleanup-candidate An inactive issue that has been marked for automated closure. tenet-performance-benchmarks Issue from performance benchmark
Milestone

Comments

@ahsonkhan
Copy link
Contributor

We should add performance tests to https://github.com/dotnet/performance and compare scenarios against Newtonsoft.Json.

This includes scenarios such as :

  • JsonNode.Parse (versus JsonDocument.Parse)
  • JsonNode.DeepCopy
  • Create JsonElement, modify some properties, and then convert back to JsonElement.
  • Enumerate all the nodes/tokens from a JsonNode (versus JsonDocument/JsonElement).

cc @kasiabulat, @joperezr

@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@msftgits msftgits added this to the 5.0 milestone Feb 1, 2020
@layomia layomia modified the milestones: 5.0, Future Apr 7, 2020
@ghost
Copy link

ghost commented Oct 15, 2021

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of the experimental issue cleanup initiative we are currently trialing in a limited number of areas. Please share any feedback you might have in the linked issue.

@steveharter steveharter self-assigned this Oct 18, 2021
@steveharter steveharter modified the milestones: Future, 7.0.0 Oct 18, 2021
@ghost
Copy link

ghost commented Nov 5, 2021

This issue will now be closed since it had been marked no recent activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.

@ghost ghost closed this as completed Nov 5, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 5, 2021
@eiriktsarpalis eiriktsarpalis added the backlog-cleanup-candidate An inactive issue that has been marked for automated closure. label Feb 18, 2022
@ghost ghost removed the no-recent-activity label Feb 18, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json backlog-cleanup-candidate An inactive issue that has been marked for automated closure. tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

5 participants