Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit the existing System.Numerics tests to validate the inputs are not all the same #30420

Closed
tannergooding opened this issue Jul 30, 2019 · 1 comment
Closed

Audit the existing System.Numerics tests to validate the inputs are not all the same #30420

tannergooding opened this issue Jul 30, 2019 · 1 comment
Labels
area-System.Numerics help wanted [up-for-grabs] Good issue for external contributors
Milestone
5.0.0

Comments

@tannergooding
Copy link
Member

It was discovered that dotnet/corefx#31779 introduced a regression due to the values for certain tests being the same between the LHS and RHS inputs.

We should audit the tests to ensure that they are testing unique inputs as well so that core functionality isn't missed and more regressions aren't introduced.
@aashikgowda
Copy link
Contributor

aashikgowda commented Aug 24, 2019 •
edited
Loading

I have a PR for this issue. Changed tests in System.Numeric.Tests.Matrix3x2Tests and System.Numeric.Tests.Matrix4x4Tests to have unique inputs for matrix add, subtract and multiplication tests.

@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@msftgits msftgits added this to the 5.0 milestone Feb 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Numerics help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
3 participants
@msftgits @tannergooding @aashikgowda