Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Utf8JsonWriter code to remove code duplication #29305

Closed
ahsonkhan opened this issue Apr 18, 2019 · 2 comments
Closed

Refactor Utf8JsonWriter code to remove code duplication #29305

ahsonkhan opened this issue Apr 18, 2019 · 2 comments
Labels
area-System.Text.Json backlog-cleanup-candidate An inactive issue that has been marked for automated closure.
Milestone
Future

Comments

@ahsonkhan
Copy link
Contributor

The Utf8JsonWriter DCR here: dotnet/corefx#36961 introduced some code duplication which can be re-factored into helper methods to avoid duplication (for example writing property names, or using write literal helper for formatted numbers as well, etc.).
@ahsonkhan ahsonkhan self-assigned this Apr 18, 2019
@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@msftgits msftgits added this to the Future milestone Feb 1, 2020
@ahsonkhan ahsonkhan removed their assignment Feb 19, 2020
@ghost
Copy link

ghost commented Oct 15, 2021

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of the experimental issue cleanup initiative we are currently trialing in a limited number of areas. Please share any feedback you might have in the linked issue.

@ghost
Copy link

ghost commented Nov 5, 2021

This issue will now be closed since it had been marked no recent activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.

@ghost ghost closed this as completed Nov 5, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 5, 2021
@eiriktsarpalis eiriktsarpalis added the backlog-cleanup-candidate An inactive issue that has been marked for automated closure. label Feb 18, 2022
@ghost ghost removed the no-recent-activity label Feb 18, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Text.Json backlog-cleanup-candidate An inactive issue that has been marked for automated closure.
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@eiriktsarpalis @ahsonkhan @msftgits