Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate feasibility of storing the JsonReaderState as a field within Utf8JsonReader #27840

Closed
ahsonkhan opened this issue Nov 7, 2018 · 2 comments
Closed

Evaluate feasibility of storing the JsonReaderState as a field within Utf8JsonReader #27840

ahsonkhan opened this issue Nov 7, 2018 · 2 comments
Labels
area-System.Text.Json backlog-cleanup-candidate An inactive issue that has been marked for automated closure. enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors tenet-performance Performance related issue
Milestone
Future

Comments

@ahsonkhan
Copy link
Contributor

For context:
dotnet/corefx#33216 (comment)

  • Consider passing the state it by ref
  • Measure performance impact

cc @stephentoub, @KrzysztofCwalina
@ahsonkhan ahsonkhan self-assigned this Nov 7, 2018
@ahsonkhan ahsonkhan changed the title Evaluate feasibility of storing the JsonReaderState as field within Utf8JsonReader Evaluate feasibility of storing the JsonReaderState as a field within Utf8JsonReader Nov 7, 2018
@ahsonkhan ahsonkhan removed their assignment Jun 4, 2019
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@layomia layomia added the help wanted [up-for-grabs] Good issue for external contributors label Mar 27, 2020
@layomia layomia modified the milestones: Future, 5.0 Mar 27, 2020
@layomia layomia modified the milestones: 5.0.0, Future Jun 20, 2020
@ghost
Copy link

ghost commented Oct 15, 2021

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of the experimental issue cleanup initiative we are currently trialing in a limited number of areas. Please share any feedback you might have in the linked issue.

@ghost
Copy link

ghost commented Nov 5, 2021

This issue will now be closed since it had been marked no recent activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.

@ghost ghost closed this as completed Nov 5, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 5, 2021
@eiriktsarpalis eiriktsarpalis added the backlog-cleanup-candidate An inactive issue that has been marked for automated closure. label Feb 18, 2022
@ghost ghost removed the no-recent-activity label Feb 18, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Text.Json backlog-cleanup-candidate An inactive issue that has been marked for automated closure. enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors tenet-performance Performance related issue
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@eiriktsarpalis @ahsonkhan @msftgits @layomia