Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change the default of cpu group to be enabled on Windows #13465

Closed
Maoni0 opened this issue Sep 23, 2019 · 3 comments
Closed

change the default of cpu group to be enabled on Windows #13465

Maoni0 opened this issue Sep 23, 2019 · 3 comments
Labels
area-GC-coreclr os-windows
Milestone
7.0.0

Comments

@Maoni0
Copy link
Member

Maoni0 commented Sep 23, 2019

historically the default has been disabled. in 3.0 by default we will use > 64 procs on linux since we got rid of the (simulated) cpu group concept there. we should change the default on windows to match this.
this includes changing the default for both GCCpuGroup and Thread_UseAllCpuGroups.

CC @janvorli
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 5.0 milestone Jan 31, 2020
@Maoni0 Maoni0 modified the milestones: 5.0.0, 6.0.0 Jul 14, 2020
@mangod9 mangod9 modified the milestones: 6.0.0, 7.0.0 Jul 9, 2021
@AntonLapounov
Copy link
Member

In Windows 11 processes are no longer constrained to a single processor group by default. I guess that means we should consider both GCCpuGroup and Thread_UseAllCpuGroups enabled by default. See related issue #67180.

@AntonLapounov AntonLapounov mentioned this issue May 11, 2022
Merged
@mangod9
Copy link
Member

mangod9 commented Jul 27, 2022

do we still need for tracking, given the linked issue is closed?

@mangod9
Copy link
Member

mangod9 commented Aug 4, 2022

Resolving this as a dupe of #67180. Anton is working on getting his PR: #68639 merged in 7

@mangod9 mangod9 closed this as completed Aug 4, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-GC-coreclr os-windows
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
4 participants
@msftgits @Maoni0 @AntonLapounov @mangod9