Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Physical promotion enhancements #110642

Open
15 tasks
jakobbotsch opened this issue Dec 12, 2024 · 2 comments
Open
15 tasks

JIT: Physical promotion enhancements #110642

jakobbotsch opened this issue Dec 12, 2024 · 2 comments
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone

Comments

@jakobbotsch
Copy link
Member

jakobbotsch commented Dec 12, 2024

This issue captures a list of potential enhancements to physical promotion, in no particular order.

CQ

Throughput

  • Stop tracking accesses early when we know we won't promote

Related issues

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 12, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Dec 12, 2024
@jakobbotsch jakobbotsch added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Dec 12, 2024
@jakobbotsch jakobbotsch added this to the Future milestone Dec 12, 2024
@jakobbotsch jakobbotsch self-assigned this Dec 12, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jakobbotsch
Copy link
Member Author

A case from @hez2010 where we don't get good codegen on SysV today because some struct fields do not map cleanly to parameter registers:

public class Program
{
    public static void Main()
    {
        GetDistance<float>(default, default);
    }

    record struct Point<T>(T X, T Y) where T : INumberBase<T>, IRootFunctions<T>;

    [MethodImpl(MethodImplOptions.NoInlining)]
    static T GetDistance<T>(Point<T> p1, Point<T> p2) where T : INumber<T>, IRootFunctions<T>
    {
        T dx = p1.X - p2.X;
        T dy = p1.Y - p2.Y;
        return T.Sqrt(dx * dx + dy * dy);
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

No branches or pull requests

1 participant