Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add analyzer: Virtual member is never overridden #106910

Closed
xtqqczze opened this issue Jul 6, 2024 · 3 comments
Closed

Add analyzer: Virtual member is never overridden #106910

xtqqczze opened this issue Jul 6, 2024 · 3 comments
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation area-Meta code-analyzer Marks an issue that suggests a Roslyn analyzer needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration
Milestone
Future

Comments

@xtqqczze
Copy link
Contributor

xtqqczze commented Jul 6, 2024

Is there an issue tracking a Roslyn analyzer for: "virtual member is never overridden"?

https://www.jetbrains.com/help/resharper/VirtualMemberNeverOverridden.Global.html

Originally posted by @xtqqczze in #104483 (comment)
@buyaa-n
Copy link
Contributor

buyaa-n commented Aug 23, 2024

New analyzer => moving to runtime.

@xtqqczze more details about how the analyzer should detect that Virtual member is never overridden would be appreciated

@buyaa-n buyaa-n transferred this issue from dotnet/roslyn-analyzers Aug 23, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 23, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Aug 23, 2024
@buyaa-n buyaa-n added api-suggestion Early API idea and discussion, it is NOT ready for implementation area-Meta code-analyzer Marks an issue that suggests a Roslyn analyzer needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration and removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 23, 2024
@buyaa-n buyaa-n added this to the Future milestone Aug 23, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

@jeffhandley
Copy link
Member

There's not enough information to make this actionable. For new analyzer suggestions, it's helpful to illustrate call sites where the diagnostic would show up as well as call sites where no diagnostic would appear.

@jeffhandley jeffhandley closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation area-Meta code-analyzer Marks an issue that suggests a Roslyn analyzer needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@jeffhandley @buyaa-n @xtqqczze