System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail [FAIL] #103784
Assignees
Labels
area-System.Text.Json
blocking-clean-ci
Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
Known Build Error
Use this to report build issues in the .NET Helix tab
Milestone
Comments
tarekgh
added
blocking-clean-ci
dotnet-policy-service
bot
added
the
untriaged
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
|
Going to keep open until the hit counts falls back to zero. |
|
Failed in: runtime-coreclr libraries-pgo 20240622.1 Failed tests: Error message: Stack trace: More failures
|
|
Failed in: runtime-coreclr libraries-jitstress 20240624.1 Failed tests: Error message: Stack trace:
More failures
|
|
eiriktsarpalis this test is still failing in our test pipelines as reported by v-wenyuxu above and in our intenal SPMI collection pepieline (failed on 6/23), which is limiting JIT team's test capability (runtime-coreclr superpmi-collect pipeline). Could you please take a look again? |
|
@JulieLeeMSFT I'm seeing the 24 hour hit counts drop. Given that this was only fixed a few days back I would assume this is because of PR branches that haven't been rebased on top of the latest main. |
dotnet-policy-service
bot
removed
the
untriaged
|
Failed in: runtime-coreclr libraries-jitstress 20240625.1 Failed tests: Error message: Stack trace:
More failures
|
|
@v-wenyuxu could you share the commit hashes of the impacted builds? We need to validate that it incorporates d9b9676 |
|
Here is an example run from 4 hours ago on main that has the failure: https://dev.azure.com/dnceng-public/public/_build/results?buildId=720735&view=results. Commit hash is eb29166. |
|
FWIW it seems to be JIT optimization sensitive, so it may be a JIT bug. The repro seems to require |
|
The method is just the lambda right above the failing assertion, but I see no issue there. It just throws a |
|
There is definitely something odd going on given that it stops reproducing with |
|
The indexer here: Resolves to the indexer on runtime/src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonNode.cs Lines 236 to 246 in a95e718 This in turn directly calls That one doesn't seem to have the check to throw with It still doesn't explain why the test does not fail in debug mode, however. |
Let me try to debug the test locally and see why it passes. |
|
Ah, it passes because the stack trace contains frames with a parameter and the test fails. In unoptimized codegen and the test passes. |
Yes, I'll follow up with a PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Build Information
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=714494
Build error leg or test failing: System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail
Pull request: #102524
Error Message
{ "ErrorMessage": "at System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail()", "ErrorPattern": "", "BuildRetry": false, "ExcludeConsoleLog": false }Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=714494
Error message validated:
[at System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail()]Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 6/22/2024 4:43:19 PM UTC
Report
Summary
The text was updated successfully, but these errors were encountered: