Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout in System.Text.Json.Tests.Utf8JsonWriterTests.WriteNumbers #101193

Closed
lewing opened this issue Apr 17, 2024 · 11 comments
Closed

Timeout in System.Text.Json.Tests.Utf8JsonWriterTests.WriteNumbers #101193

lewing opened this issue Apr 17, 2024 · 11 comments
Assignees
Labels
area-Codegen-Interpreter-mono area-System.Text.Json Known Build Error Use this to report build issues in the .NET Helix tab
Milestone

Comments

@lewing
Copy link
Member

lewing commented Apr 17, 2024

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=646861
Build error leg or test failing: System.Text.Json.Tests.WorkItemExecution
Pull request: #101140

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": [ "Takes very long to run on interpreter.", "System.Text.Json.Tests.Utf8JsonWriterTests.WriteNumbers", "['System.Text.Json.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]"],
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=646861
Error message validated: [Takes very long to run on interpreter. System.Text.Json.Tests.Utf8JsonWriterTests.WriteNumbers ['System.Text.Json.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 4/17/2024 5:06:43 PM UTC

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
@lewing lewing added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Apr 17, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Apr 17, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

@lewing
Copy link
Member Author

lewing commented Apr 17, 2024

See the discussion in #59678 for context

@lewing
Copy link
Member Author

lewing commented Apr 17, 2024

This was written to try to catch
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-101122-merge-004d05ddb3b041639a/System.Text.Json.Tests/1/console.8d81d47f.log?helixlogtype=result


/datadisks/disk1/work/9B2B0894/w/B43409F0/e /datadisks/disk1/work/9B2B0894/w/B43409F0/e
  Discovering: System.Text.Json.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Text.Json.Tests (found 7405 of 7466 test cases)
  Starting:    System.Text.Json.Tests (parallel test collections = on [2 threads], stop on fail = off)
    System.Text.Json.Tests.Utf8JsonReaderTests.TestDepth(depth: 256) [SKIP]
      Takes very long to run on interpreter.
    System.Text.Json.Tests.Utf8JsonReaderTests.TestDepth(depth: 512) [SKIP]
      Takes very long to run on interpreter.
   System.Text.Json.Tests: [Long Running Test] 'System.Text.Json.Tests.Utf8JsonWriterTests.Writing3MBBase64Bytes', Elapsed: 00:05:42
   System.Text.Json.Tests: [Long Running Test] 'System.Text.Json.Tests.Utf8JsonWriterTests.WriteNumbers', Elapsed: 00:02:01
   System.Text.Json.Tests: [Long Running Test] 'System.Text.Json.Tests.Utf8JsonWriterTests.WriteNumbers', Elapsed: 00:04:01
Killed
['System.Text.Json.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]

as explicitly as possible but there are a lot of other forms of timeouts for wasm

@lewing
Copy link
Member Author

lewing commented Apr 17, 2024

@BrzVlad the particular failure this issue seems to catch looks like it is specfic to the desktop interpreter, can you take a look?

Copy link
Contributor

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

@BrzVlad
Copy link
Member

BrzVlad commented Apr 18, 2024

I did a few runs locally and I'm not seeing anything suspicious. It just looks like a heavy suite that takes a long time to run. Also I'm seeing that all these failures are on debug builds. While for jit/aot, debug build doesn't have a big impact, the interpreter execution engine is written in C and it can easily get 3x slower in debug build.

I'm not sure if it easy to do, but I think this test suite should be disabled on interpreter debug builds

@eiriktsarpalis eiriktsarpalis added this to the 9.0.0 milestone Apr 19, 2024
@eiriktsarpalis eiriktsarpalis removed the untriaged New issue has not been triaged by the area owner label Apr 19, 2024
@BrzVlad
Copy link
Member

BrzVlad commented Apr 24, 2024

Disabled suite in debug runtime builds in /github.com//pull/101483

@BrzVlad BrzVlad closed this as completed Apr 24, 2024
@lewing
Copy link
Member Author

lewing commented Apr 25, 2024

reopening since a few builds weren't against the tip of main and hit this, feel free to close again next week

@lewing lewing reopened this Apr 25, 2024
@jeffschwMSFT jeffschwMSFT removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Jun 18, 2024
@jeffschwMSFT
Copy link
Member

removing blocking-clean-ci as it has not failed in 30 days

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0

@eiriktsarpalis
Copy link
Member

Fixed by #101556

@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Codegen-Interpreter-mono area-System.Text.Json Known Build Error Use this to report build issues in the .NET Helix tab
Projects
None yet
Development

No branches or pull requests

4 participants