From cfaf8d9a917ebfe2c757bae483a5731a1d66d94d Mon Sep 17 00:00:00 2001 From: lateralusX Date: Mon, 22 Jan 2024 12:37:29 +0100 Subject: [PATCH] Fix review feedback. --- .../System.Private.CoreLib.Shared.projitems | 42 +++++++++---------- src/mono/mono/mini/simd-intrinsics.c | 11 +---- 2 files changed, 23 insertions(+), 30 deletions(-) diff --git a/src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems b/src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems index a0a2501984f698..94089d1018d8d1 100644 --- a/src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems +++ b/src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems @@ -2575,27 +2575,27 @@ - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + - - + + @@ -2606,8 +2606,8 @@ - - + + diff --git a/src/mono/mono/mini/simd-intrinsics.c b/src/mono/mono/mini/simd-intrinsics.c index b855dec613bb98..f37bbf83aedcda 100644 --- a/src/mono/mono/mini/simd-intrinsics.c +++ b/src/mono/mono/mini/simd-intrinsics.c @@ -1436,15 +1436,8 @@ emit_sri_vector (MonoCompile *cfg, MonoMethod *cmethod, MonoMethodSignature *fsi else return NULL; - if (vector_size == 256 || vector_size == 512) { - if (id == SN_get_IsHardwareAccelerated ) { - MonoInst* ins; - EMIT_NEW_ICONST (cfg, ins, 0); - return ins; - } - + if (vector_size == 256 || vector_size == 512) return NULL; - } // FIXME: This limitation could be removed once everything here are supported by mini JIT on arm64 #ifdef TARGET_ARM64 @@ -6163,7 +6156,7 @@ mono_simd_unsupported_aggressive_inline_intrinsic_type (MonoMethod *cmethod) if (!strcmp (m_class_get_name_space (cmethod->klass), "System.Runtime.Intrinsics")) { if (!strncmp(m_class_get_name (cmethod->klass), "Vector", 6)) { const char *vector_type = m_class_get_name (cmethod->klass) + 6; - if (!!strcmp(vector_type, "256`1") || !strcmp(vector_type, "512`1")) + if (!strcmp(vector_type, "256`1") || !strcmp(vector_type, "512`1")) return TRUE; } }