Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCS1244 false-positive in statement lambdas #957

Closed
jhinder opened this issue Sep 29, 2022 · 0 comments · Fixed by #966
Closed

RCS1244 false-positive in statement lambdas #957

jhinder opened this issue Sep 29, 2022 · 0 comments · Fixed by #966

Comments

@jhinder
Copy link

jhinder commented Sep 29, 2022

Product and Version Used: Roslynator 4.1.1 in VS 17.3.5

Steps to Reproduce:
Apply the codefix for RCS1244 on the default() expression.

var x = () =>
{
    return default(object);
               // ~~~~~~~~ RCS1244: Simplify 'default' expression
};

This affects statement lambdas, but not expression lambdas.

var x = () => default(object); // No diagnostics

Actual Behavior:
The argument is removed, leaving a typeless default literal.

var x = () =>
{
    return default;
        // ~~~~~~~ CS8917: There is no target type for the default literal
};

Expected Behavior:
The codefix is not offered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants