Do not offer use-conditional when it would cause name collisions #76807
+133
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Jan 18, 2025
src/Analyzers/CSharp/Analyzers/UseDeconstruction/CSharpUseDeconstructionDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
…nstructionDiagnosticAnalyzer.cs
CyrusNajmabadi
commented
Jan 18, 2025
| // Ignore an anonymous type property or tuple field. It's ok if they have a name that | ||
| // matches the name of the local we're introducing. | ||
| return semanticModel.GetAllDeclaredSymbols(container, cancellationToken, descendInto) | ||
| .Where(s => !s.IsAnonymousTypeProperty() && !s.IsTupleField()); |
There was a problem hiding this comment.
i moved this filtering into GetAllDeclaredSymbols as all callers want this behavior.
CyrusNajmabadi
commented
Jan 18, 2025
| // matches the name of the local we're introducing. | ||
| return semanticModel.GetAllDeclaredSymbols(container, cancellationToken) | ||
| .Where(s => !s.IsAnonymousTypeProperty() && !s.IsTupleField()); | ||
| return semanticModel.GetAllDeclaredSymbols(container, cancellationToken); |
There was a problem hiding this comment.
these checks moved into GetAllDeclaredSymbols .
|
@JoeRobich @ToddGrun This is ready for review, and is the last open bug in the 'use conditional expr' area. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72464
Followup to #76798