Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion for global using static attempts to insert a regular using #68791

Closed
333fred opened this issue Jun 26, 2023 · 2 comments · Fixed by #69691
Closed

Completion for global using static attempts to insert a regular using #68791

333fred opened this issue Jun 26, 2023 · 2 comments · Fixed by #69691
Assignees
@genlu
Labels
Area-IDE Bug IntelliSense-Completion VSCode
Milestone
Post GA

Comments

@333fred
Copy link
Member

333fred commented Jun 26, 2023

Version Used: VSCode 1.80.0-insider, C# extension v2.0.246-gc81fc4a054

Steps to Reproduce:

  1. Go to the top of a C# file.
  2. Type global using static List
  3. Hit enter to accept the suggestion for List<T> from System.Collections.Generic

Expected Behavior:

global using static System.Collections.Generic.List is inserted.

Actual Behavior:

image
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 26, 2023
@333fred 333fred added the Bug label Jun 26, 2023
@333fred
Copy link
Member Author

333fred commented Jun 26, 2023

FYI @genlu.

@333fred
Copy link
Member Author

333fred commented Jun 26, 2023

The regular using version is slightly better:
image

Still not correct code (no regular using should be inserted, as it needs to be fully qualified there), but at least it's not syntactically garbled.

@genlu genlu added VSCode IntelliSense-Completion and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 25, 2023
@genlu genlu self-assigned this Jul 25, 2023
@genlu genlu added this to the Post GA milestone Jul 25, 2023
@genlu genlu mentioned this issue Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@genlu genlu

Labels
Area-IDE Bug IntelliSense-Completion VSCode
Projects
None yet
Milestone
Post GA
Development

Successfully merging a pull request may close this issue.

Fix import completion in LSP workspace genlu/roslyn
2 participants
@genlu @333fred