Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TargetFramework.Net70 #61463

Closed
jcouv opened this issue May 23, 2022 · 0 comments · Fixed by #64490
Closed

Add TargetFramework.Net70 #61463

jcouv opened this issue May 23, 2022 · 0 comments · Fixed by #64490
Assignees
@jaredpar
Labels
Area-Compilers Feature - Ref Fields Test Test failures in roslyn-CI
Milestone
17.4

Comments

@jcouv
Copy link
Member

jcouv commented May 23, 2022 •
edited
Loading

The "numeric IntPtr" and "ref field" tests currently use a test hook to pretend like RuntimeFeature.NumericIntPtr and RuntimeFeature.ByRefFields exist. Once a BCL that actually supports numeric IntPtr and ref fields becomes available, we should make it available in our tests and use that instead.

Also, I don't think we execute any ref fields tests via CompileAndVerify at the moment (the code is there, but never exercised in CI).

This issue is referenced in source and tests.

Relates to test plan #60578

PR that added Net60.
@jcouv jcouv added Area-Compilers Test Test failures in roslyn-CI labels May 23, 2022
@jcouv jcouv added this to the C# 11.0 milestone May 23, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label May 23, 2022
@jcouv jcouv mentioned this issue May 23, 2022
Closed
49 tasks
@jcouv jcouv removed the untriaged Issues and PRs which have not yet been triaged by a lead label May 24, 2022
@jaredpar jaredpar modified the milestones: C# 11.0, 17.4 Jun 24, 2022
@jcouv jcouv changed the title Add TargetFramework.Net70 with "numeric IntPtr" support Add TargetFramework.Net70 Jul 29, 2022
@jcouv jcouv mentioned this issue Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaredpar jaredpar

Labels
Area-Compilers Feature - Ref Fields Test Test failures in roslyn-CI
Projects
None yet
Milestone
17.4
Development

Successfully merging a pull request may close this issue.

Add and use TargetFramework.Net70 jcouv/roslyn
3 participants
@jaredpar @cston @jcouv