Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated syntax trees should respect analyzer config options #44223

Closed
chsienki opened this issue May 13, 2020 · 2 comments
Closed

Generated syntax trees should respect analyzer config options #44223

chsienki opened this issue May 13, 2020 · 2 comments
Assignees
@chsienki
Labels
Area-Compilers Bug Feature - Source Generators Source Generators
Milestone
16.8

Comments

@chsienki
Copy link
Contributor

We should pass the AnalyzerConfigSet to the source generator so that we can parse the generated trees according to any rules specified within.

This will also allow us to pass the options for each tree out from the generator and onto to the later stages of compilation, reducing duplicate work.

A workaround for this was introduced in #44221
@chsienki chsienki self-assigned this May 13, 2020
@chsienki chsienki mentioned this issue May 13, 2020
Merged
@chsienki
Copy link
Contributor Author

This is the underlying fix for #44087

@chsienki chsienki mentioned this issue May 19, 2020
Closed
@jaredpar jaredpar added the Bug label Jul 9, 2020
@jaredpar jaredpar added this to the 16.8 milestone Jul 9, 2020
@chsienki chsienki mentioned this issue Sep 3, 2020
Open
@chsienki
Copy link
Contributor Author

Fixed by #44875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chsienki chsienki

Labels
Area-Compilers Bug Feature - Source Generators Source Generators
Projects
None yet
Milestone
16.8
Development

No branches or pull requests
2 participants
@jaredpar @chsienki