Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INamedTypeSymbol.TupleUnderlyingType should return null rather than this #41702

Closed
cston opened this issue Feb 14, 2020 · 0 comments · Fixed by #41828
Closed

INamedTypeSymbol.TupleUnderlyingType should return null rather than this #41702

cston opened this issue Feb 14, 2020 · 0 comments · Fixed by #41828
Assignees
@cston
Labels
Area-Compilers
Milestone
16.5

Comments

@cston
Copy link
Member

cston commented Feb 14, 2020 •
edited
Loading

The behavior of INamedTypeSymbol.TupleUnderlyingType should return null rather than this when the type is a tuple without names, to avoid breaking existing callers.

If the caller recurses on TupleUnderlyingType, returning this could lead to a StackOverflowException that will crash the process.

The behavior changed in #39370.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cston cston

Labels
Area-Compilers
Projects
None yet
Milestone
16.5
Development

Successfully merging a pull request may close this issue.

Return null rather than this from INamedTypeSymbol.TupleUnderlyingType cston/roslyn
1 participant
@cston