Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to port Rule Sets to EditorConfig #41393

Closed
mikadumont opened this issue Feb 4, 2020 · 6 comments
Closed

Ability to port Rule Sets to EditorConfig #41393

mikadumont opened this issue Feb 4, 2020 · 6 comments
Labels
Area-Analyzers Feature Request Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone

Comments

@mikadumont
Copy link
Contributor

No description provided.

@mavasani
Copy link
Contributor

mavasani commented Feb 4, 2020

We implemented this in VS2019 16.5 Preview2. There is also a NuGet package Microsoft.CodeAnalysis.RulesetToEditorconfigConverter that enables the conversion from command line.

I also added documentation for this in https://github.com/MicrosoftDocs/visualstudio-docs-pr/pull/5828/files#diff-a4705fb2096f08b51b83a5701a483c76R129, which is not yet published on docs.microsoft.com, it will be once 16.5 is released.

@jmarolf
Copy link
Contributor

jmarolf commented Feb 4, 2020

@mavasani I assume there is no way to convert automatically from within VS (I can't navigate to the docs link)?

@mavasani
Copy link
Contributor

mavasani commented Feb 4, 2020

If you open the ruleset file in ruleset editor, you should see an infobar at the top, which allows converting the ruleset to .editorconfig. We also talked about potentially offering a context menu on ruleset files in solution explorer to invoke the conversion and also about having an IDE suggestion in error list with a special context menu item to perform conversion, but nothing else is planned to implemented as of now.

@mavasani
Copy link
Contributor

mavasani commented Feb 4, 2020

RE: docs link requires you to have permission for that repo. Let me forward you the email with details.

@jinujoseph jinujoseph added Area-Analyzers Feature Request Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented labels Feb 4, 2020
@jinujoseph jinujoseph added this to the Backlog milestone Feb 4, 2020
@stogle
Copy link

stogle commented Jul 9, 2020

I have Visual Studio 16.6.2 and I'm not seeing the info bar when I open the ruleset I'm using in my solution. Under what conditions is it supposed to show?

@mavasani
Copy link
Contributor

mavasani commented Jul 9, 2020

@stogle It only shows up if the ruleset is not used from any native/C++ project context, as those projects still need ruleset for configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Analyzers Feature Request Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Development

No branches or pull requests

5 participants