Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostic to suggest replacing write-only properties with methods #30983

Closed
mavasani opened this issue Nov 6, 2018 · 2 comments
Closed

Diagnostic to suggest replacing write-only properties with methods #30983

mavasani opened this issue Nov 6, 2018 · 2 comments
Labels
Area-IDE Feature Request Need Design Review The end user experience design needs to be reviewed and approved.
Milestone
Backlog

Comments

@mavasani
Copy link
Contributor

mavasani commented Nov 6, 2018

See discussions in #30894
@mavasani mavasani mentioned this issue Nov 6, 2018
Closed
@CyrusNajmabadi
Copy link
Member

Note: as per discussions in other PRs, this should be under a code-quality bucket. Though, IMO, i'm pretty heavily against us having a diagnostic here period. I think it's extremely strange for us to be telling someone "you shouldn't have a write-only property". What is that based on? What group came up with that guidance? What is the policy by which we determine if/when something is low/high quality?

With 'style' it was pretty simple, we could see large communities of people wanting to be able to pick a stylistic choice. i.e. having 'var' or an 'explicit' type is a choice within a method that doesn't impact your surface area/API. We're now getting into the realm of API checking, and that is definitely not a 'style' concern.

@jinujoseph jinujoseph added this to the Unknown milestone Nov 6, 2018
@jinujoseph jinujoseph added the Need Design Review The end user experience design needs to be reviewed and approved. label Nov 6, 2018
@CyrusNajmabadi
Copy link
Member

@mavasani can you move to Roslyn-Analyzers. This doesn't really fit into core Roslyn IDE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Feature Request Need Design Review The end user experience design needs to be reviewed and approved.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@CyrusNajmabadi @mavasani @jinujoseph