It feels like Microsoft.CodeAnalysis.CSharp.Symbols.SourceUserDefinedOperatorSymbolBase.CheckUserDefinedConversionSignature Should ignore tuple names when type symbols are compared

[AlekseyTs]

            // SPEC: * S0 and T0 are different types:

            if ((ContainingType.SpecialType == SpecialType.System_Nullable_T) ? source == target : source0 == target0)

            if (source0 == this.ContainingType)
            {
                same = source;
                different = target;
            }
            else
            {
                same = target;
                different = source;
            }

[RikkiGibson]

Is the comparison in question the source0 == this.ContainingType? It seems like comparing to SpecialType.System_Nullable_T shouldn't require tuple-specific compare kinds.

[RikkiGibson]

This code seems to work--am I missing something about what this change is meant to fix?

namespace System
{
    struct ValueTuple<T1, T2>
    {
        public static explicit operator (T1 fst, T2 snd)((T1 one, T2 two) tuple)
        {
            return tuple;
        }
    }
}

https://sharplab.io/#v2:C4LglgNgNAJiDUAfAdgQwLYFMDOAHVAxpgAQACAjALABQA3jcY8dsAE4CuBwxAaqhO0wAVdrgiYAPEPJRiQgEwA+Bk3rUmGsgGYy5AGzFMADzFgCYbgHtcmVqmCXWxABTTiAMxayFzZDACUzq7kxJbImN7yxMAA7pb+0aLi/iqaxGppaaQA7IlimADcqZoAvsVl1CVAA

[AlekseyTs]

@RikkiGibson Let's discuss questions you have offline.