Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build instructions for windows #23514

Closed
MaStr11 opened this issue Dec 1, 2017 · 3 comments
Closed

Update build instructions for windows #23514

MaStr11 opened this issue Dec 1, 2017 · 3 comments

Comments

@MaStr11
Copy link
Contributor

MaStr11 commented Dec 1, 2017

Since #22812 roslyn only builds with VS 15.5 Preview. The build instruction for windows should be updated:

  • Minimum Version is 15.5 Preview
  • Required SDK is 2.1.1 (couldn't find any download link for this)
  • SDK 2.1.1 installs with VS 15.5 Preview
@sharwell
Copy link
Member

sharwell commented Dec 1, 2017

@dotnet/roslyn-compiler We should make sure to track this as a key part of updating the compiler version since it's likely to happen again in the future.

@jasonmalinowski
Copy link
Member

Oops, that was actually an oversight: we intentionally didn't want master to have that dependency until 15.5 shipped in a non-Preview form.

@jaredpar
Copy link
Member

jaredpar commented Dec 1, 2017

The changes for the SDK links and versions is already in PR.

#23494

Oops, that was actually an oversight: we intentionally didn't want master to have that dependency until 15.5 shipped in a non-Preview form.

Agree. We did this work initially in the post-dev15.5-contrib branch. The assumption was that wouldn't be merged until 15.5 was public. That turned out to not be true though.

@jcouv jcouv added this to the 15.6 milestone Dec 6, 2017
@jcouv jcouv modified the milestones: 15.6, 15.7 Jan 23, 2018
@jcouv jcouv modified the milestones: 15.7, 15.8 Mar 27, 2018
@jcouv jcouv modified the milestones: 15.8, 15.9 Jun 30, 2018
@jcouv jcouv modified the milestones: 15.9, 16.0 Jul 7, 2018
@jaredpar jaredpar closed this as completed Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants