Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify the behavior of dynamic in deconstructions #12398

Closed
jcouv opened this issue Jul 8, 2016 · 1 comment · Fixed by #13724
Closed

Verify the behavior of dynamic in deconstructions #12398

jcouv opened this issue Jul 8, 2016 · 1 comment · Fixed by #13724
Assignees
Labels
Area-Compilers Feature - Tuples Tuples Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone

Comments

@jcouv
Copy link
Member

jcouv commented Jul 8, 2016

Confirm whether the following code is correct:

    private ImmutableArray<BoundExpression> LeftHandSideSideEffects(ImmutableArray<BoundExpression> variables, ArrayBuilder<LocalSymbol> temps, ArrayBuilder<BoundExpression> stores)
        {
            var lhsReceivers = ArrayBuilder<BoundExpression>.GetInstance(variables.Length);

            foreach (var variable in variables)
            {
                // PROTOTYPE(tuples) should the dynamic flag always be false?
                lhsReceivers.Add(TransformCompoundAssignmentLHS(variable, stores, temps, isDynamicAssignment: false));
            }

            return lhsReceivers.ToImmutableAndFree();
        }

in LocalRewriter_DeconstructionAssignmentOperator.cs

@jcouv jcouv self-assigned this Jul 8, 2016
@jcouv jcouv modified the milestones: 2.0 (Preview 4), 2.0 (RC) Jul 11, 2016
@jaredpar jaredpar modified the milestones: 2.0 (RC), 2.0 (RTM) Jul 18, 2016
@jcouv jcouv modified the milestones: 2.0 (Preview 5), 2.0 (RTM) Sep 3, 2016
@jaredpar jaredpar modified the milestones: 2.0 (RTM), 2.0 (Preview 5) Sep 9, 2016
@jcouv jcouv modified the milestones: 2.0 (RC), 2.0 (RTM) Sep 10, 2016
@jcouv jcouv added the 4 - In Review A fix for the issue is submitted for review. label Sep 11, 2016
@RussKeldorph RussKeldorph removed the 4 - In Review A fix for the issue is submitted for review. label Sep 12, 2016
@jcouv
Copy link
Member Author

jcouv commented Sep 12, 2016

Fixed by #13724

@jcouv jcouv added the Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented label Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Feature - Tuples Tuples Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants