-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Roslyn components multi-targeting #5816
Comments
YairHalberstadt/stronginject@40c2721 for an example where this was done. |
This may help reduce the amount of reflection we do, ie, in |
Actually we might completely get rid of |
There are two big problems with Roslyn component versioning today:
|
@sharwell I thought the SDK version requirement would be for roslyn-analyzers repository, not consumers. But looks like my assumption was wrong? |
Component versioning is a consumer/client feature implemented by NuGet and/or the SDK. |
@sharwell Is it expected that it can (at some point in future) be a good fit to use? If it's not a good fit, we can probably close this issue? |
I guess it depends on what versions of the compiler need to be supported over time. There are some partial workarounds available to handle cases where the feature is/is not supported. |
We're using an old version of Roslyn to allow consumption in old VS versions. But this comes with some issues where a given Roslyn API had a bug that was fixed in a later version, and updating to new version of Roslyn is blocked.
Another benefit is we'll have more up-to-date nullable annotations, which can help prevent bugs (e.g #5802).
As of dotnet/sdk#20793, there is now a support for targeting multiple versions of Roslyn, where the highest version that can work will be picked. I think it would be useful if we used that in roslyn-analyzers.
The text was updated successfully, but these errors were encountered: