New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement for "CA1852: Seal internal/private types" #5678

Open

Youssef1313 opened this issue Oct 25, 2021 · 1 comment

Labels

Area-Microsoft.CodeAnalysis.NetAnalyzers Enhancement

Member

Youssef1313 commented Oct 25, 2021

Does it make sense to extend this to public types where the base type doesn't have any public constructors?

If it doesn't have any public, protected, or protected internal constructors, then we could also factor it in.

Originally posted by @stephentoub in dotnet/runtime#49944 (comment)

Member Author

Youssef1313 commented Oct 25, 2021

Analyzer is currently WIP: #5594

cc @NewellClark

Youssef1313 changed the title ~~Enhancement for "Seal internal/private types"~~ Enhancement for "CA1852: Seal internal/private types"

Youssef1313 added Enhancement Area-Microsoft.CodeAnalysis.NetAnalyzers labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment