Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port FxCop rule CA2232: MarkWindowsFormsEntryPointsWithStaThread #545

Open
Tracked by #61964
ghost opened this issue Nov 21, 2015 · 7 comments
Open
Tracked by #61964

Port FxCop rule CA2232: MarkWindowsFormsEntryPointsWithStaThread #545

ghost opened this issue Nov 21, 2015 · 7 comments
Labels
Approved-Rule Indicates if the new proposed rule has been approved to move to implementation phase Area-External FxCop-Port help wanted The issue is up-for-grabs, and can be claimed by commenting
Milestone

Comments

@ghost
Copy link

ghost commented Nov 21, 2015

Title: Mark Windows Forms entry points with STAThread

Description:

STAThreadAttribute indicates that the COM threading model for the application is a single-threaded apartment. This attribute must be present on the entry point of any application that uses Windows Forms; if it is omitted, the Windows components might not work correctly.

Dependency: None

Notes:

@ghost ghost added the FxCop-Port label Nov 21, 2015
@ghost ghost added the Area-DesktopAnalyzers label Dec 4, 2015
@mavasani mavasani added this to the Unknown milestone Apr 17, 2017
@Evangelink
Copy link
Member

@mavasani Is it worth moving/opening a ticket un dotnet/runtime regarding all the CA rules that are still awaiting for port? Some might no longer be relevant or context/recommendation might have changed sightly.

@mavasani
Copy link
Contributor

@Evangelink That seems reasonable to do for all .NET API related rules.

@Evangelink
Copy link
Member

Are you considering guidelines related ones (like implement serializable correctly, do this when doing a serialization method....) to also be part of the .NET API?

@mavasani
Copy link
Contributor

Yes

@Evangelink Evangelink added Approved-Rule Indicates if the new proposed rule has been approved to move to implementation phase help wanted The issue is up-for-grabs, and can be claimed by commenting labels Jan 7, 2022
@Youssef1313
Copy link
Member

Youssef1313 commented Dec 14, 2022

Best to implement this in https://github.com/dotnet/winforms/tree/main/src/System.Windows.Forms.Analyzers

See dotnet/runtime#79602 (comment)

I'll open an issue on dotnet/winforms and close this one.

@Youssef1313
Copy link
Member

Duplicate of dotnet/winforms#8384

@Youssef1313
Copy link
Member

@mavasani winforms decided to not implement this analyzer: dotnet/winforms#8384

Do we still want to implement it here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-Rule Indicates if the new proposed rule has been approved to move to implementation phase Area-External FxCop-Port help wanted The issue is up-for-grabs, and can be claimed by commenting
Projects
None yet
Development

No branches or pull requests

3 participants