Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA1416: Consider supporting guard clauses like IsThreadStartSupported #4428

Closed
buyaa-n opened this issue Nov 13, 2020 · 3 comments
Closed

CA1416: Consider supporting guard clauses like IsThreadStartSupported #4428

buyaa-n opened this issue Nov 13, 2020 · 3 comments

Comments

@buyaa-n
Copy link
Contributor

buyaa-n commented Nov 13, 2020

Consider supporting guard clauses like IsThreadStartSupported in Platform compatibility analyzer

I'd have hoped the analyzer would be able to understand the guard clauses like IsThreadStartSupported just as the linker can. Is that not possible?

Originally posted by @stephentoub in dotnet/runtime#43363 (comment)

@Evangelink
Copy link
Member

@buyaa-n could you please give a little more detail about the issue? As far as I understand the idea is to fix a false positive with the rule CA1416, is it more global? If not, maybe the title should state the rule and the label might be False-Positive instead of Enhancement.

@buyaa-n buyaa-n changed the title Consider supporting guard clauses like IsThreadStartSupported CA1416: Consider supporting guard clauses like IsThreadStartSupported Nov 29, 2020
@buyaa-n
Copy link
Contributor Author

buyaa-n commented Nov 29, 2020

@buyaa-n could you please give a little more detail about the issue? As far as I understand the idea is to fix a false positive with the rule CA1416, is it more global? If not, maybe the title should state the rule and the label might be False-Positive instead of Enhancement.

It is not a fix for a false positive, it would be an enhancement for the analyzer to support this scenario. Yes, it is related to CA1416 only, updated the title, thanks!

@buyaa-n
Copy link
Contributor Author

buyaa-n commented May 12, 2021

Fixed with #5087

@buyaa-n buyaa-n closed this as completed May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants