Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncRx.NET Distinct and DistinctUntilChanged should be extension methods #2169

Open
idg10 opened this issue Oct 7, 2024 · 0 comments
Open

Comments

@idg10
Copy link
Collaborator

idg10 commented Oct 7, 2024

Bug

The AsyncObservable class's static Distinct and DistinctUntilChanged methods are not extension methods. This means that given some:

IAsyncObservable<int> xs = GetNums();

you can't write this:

xs.Distinct(); // or DistinctUntilChanged

You have to write this:

AsyncObservable.Distinct(xs);

This seems like a straightforward oversight. We just need to add the this keyword to these methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant