Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some benchmarks for array deabstraction #4522

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Add some benchmarks for array deabstraction #4522

merged 1 commit into from
Oct 18, 2024

Conversation

AndyAyersMS
Copy link
Member

Various "equivalent" tests for enumerating arrays, illustrating the abstraction penalty.

See dotnet/runtime#108913

@AndyAyersMS
Copy link
Member Author

@DrewScoggins PTAL
cc @dotnet/jit-contrib

@AndyAyersMS AndyAyersMS mentioned this pull request Oct 16, 2024
Open
LoopedBard3
LoopedBard3 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good presuming there are no configs we need to filter out (does this work on WASM, Mono, and MonoAOT?).

@AndyAyersMS
Copy link
Member Author

Looks good presuming there are no configs we need to filter out (does this work on WASM, Mono, and MonoAOT?).

It is fairly vanilla C# so I'd hope it works everywhere.

@AndyAyersMS
Copy link
Member Author

Looks like CI is unhappy though ?

@LoopedBard3
Copy link
Member

Yea, the ci is unhappy but not due to your changes. The error we are seeing is Unable to find package Microsoft.NETCore.App.Ref with version (= 8.0.11). Not sure exactly why the main runs are hitting this, but it probably it is occurring when we build some tools so they may just need to be updated to target 9 instead of 8.

@AndyAyersMS
Copy link
Member Author

So can you merge? I can't....

@LoopedBard3 LoopedBard3 merged commit e7c42e5 into dotnet:main Oct 18, 2024
43 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoopedBard3 LoopedBard3 LoopedBard3 approved these changes

@DrewScoggins DrewScoggins Awaiting requested review from DrewScoggins

@caaavik-msft caaavik-msft Awaiting requested review from caaavik-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndyAyersMS @LoopedBard3