-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Microbenchmarks] TFMs cleanup + Microsoft.Extensions* update #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… diff shows the actual difference for Extensions benchmarks, fixes dotnet/runtime#77900
…e System.Threading.Channels do not support net461 anymore
Before: BenchmarkDotNet=v0.13.2.1940-nightly, OS=Windows 11 (10.0.22621.674)
AMD Ryzen Threadripper PRO 3945WX 12-Cores, 1 CPU, 24 logical and 12 physical cores
.NET SDK=7.0.100-rc.1.22431.12
[Host] : .NET 6.0.10 (6.0.1022.47605), X64 RyuJIT AVX2
Job-EOWPLY : .NET 6.0.10 (6.0.1022.47605), X64 RyuJIT AVX2
Job-RERDVV : .NET 7.0.0 (7.0.22.42610), X64 RyuJIT AVX2
After: BenchmarkDotNet=v0.13.2.1950-nightly, OS=Windows 11 (10.0.22621.674)
AMD Ryzen Threadripper PRO 3945WX 12-Cores, 1 CPU, 24 logical and 12 physical cores
.NET SDK=8.0.100-alpha.1.22558.1
[Host] : .NET 6.0.10 (6.0.1022.47605), X64 RyuJIT AVX2
Job-REUZGI : .NET 6.0.10 (6.0.1022.47605), X64 RyuJIT AVX2
Job-XTHPSX : .NET 7.0.0 (7.0.22.42610), X64 RyuJIT AVX2
|
It's now possible to build entire solution with no warnings:
|
LoopedBard3
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The CI failures are unrelated, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've investigated dotnet/runtime#77900 (comment) and the reason behind the "regression" was not using the appropriate version of
Microsoft.Extensions*
. These particular libraries and not shipped as part of .NET SDK (they are often called OOB: "out-of-band") and they require manual version update in the.csproj
. Since 7.0 versions of allMicrosoft.Extensions*
packages were shipped to nuget.org yesterday, it was a perfect moment to update them and theSystem*
libraries.But the
System*
libraries don't supportnet461
anymore:So I've upgraded
net461
tonet462
.Then the other warning I was getting was:
So I've removed the
net5.0
tfm. And last but not least, I've limited the test projects to target single tfm (net7.0)fixes dotnet/runtime#77900
fixes #2079