Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Linux/x64: 3 Regressions on 10/17/2022 8:10:07 PM #9199

Closed
performanceautofiler bot opened this issue Oct 25, 2022 · 3 comments
Closed

[Perf] Linux/x64: 3 Regressions on 10/17/2022 8:10:07 PM #9199

performanceautofiler bot opened this issue Oct 25, 2022 · 3 comments
Labels
arch-x64 branch-refs/heads/main kind-micro_mono mono-interpreter os-linux perf-regression runtime-mono

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Oct 25, 2022 •
edited
Loading

Run Information

Architecture x64
OS ubuntu 18.04
Baseline 6dc9a74481888a13573d90424d06484bbf425b4a
Compare 8393c4eb74afecaa70267b2a94b9b94c1d1ae384
Diff Diff

Regressions in System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
NewCustomizedOptions - Duration of single invocation 33.60 μs 36.07 μs 1.07 0.01 False
NewCachedCustomConverter - Duration of single invocation 33.93 μs 38.14 μs 1.12 0.01 False
NewDefaultOptions - Duration of single invocation 28.50 μs 32.82 μs 1.15 0.01 False

Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Text.Json.Serialization.Tests.ColdStartSerialization&lt;SimpleStructWithProperties&gt;*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties>.NewCustomizedOptions

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 36.069842068106304 > 34.98919268248797.
IsChangePoint: Marked as a change because one of 10/6/2022 12:41:43 AM, 10/17/2022 12:47:34 PM, 10/25/2022 2:56:59 AM falls between 10/16/2022 1:15:28 PM and 10/25/2022 2:56:59 AM.
IsRegressionStdDev: Marked as regression because -42.0661811721036 (T) = (0 -36881.74183740816) / Math.Sqrt((63710.77909300827 / (15)) + (87811.26525938426 / (26))) is less than -2.0226909200346674 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (15) + (26) - 2, .025) and -0.1106104009608109 = (33208.53271813504 - 36881.74183740816) / 33208.53271813504 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Text.Json.Serialization.Tests.ColdStartSerialization&lt;SimpleStructWithProperties&gt;.NewCachedCustomConverter

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 38.1422659551597 > 35.60711166285854.
IsChangePoint: Marked as a change because one of 10/6/2022 12:41:43 AM, 10/17/2022 12:47:34 PM, 10/25/2022 2:56:59 AM falls between 10/16/2022 1:15:28 PM and 10/25/2022 2:56:59 AM.
IsRegressionStdDev: Marked as regression because -59.16017410411404 (T) = (0 -38542.25865142532) / Math.Sqrt((50853.74815677655 / (15)) + (70521.21615262069 / (26))) is less than -2.0226909200346674 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (15) + (26) - 2, .025) and -0.13624546364186418 = (33920.71509609436 - 38542.25865142532) / 33920.71509609436 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Text.Json.Serialization.Tests.ColdStartSerialization&lt;SimpleStructWithProperties&gt;.NewDefaultOptions

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 32.82296550783776 > 29.901549717265205.
IsChangePoint: Marked as a change because one of 10/6/2022 12:41:43 AM, 10/17/2022 12:47:34 PM, 10/25/2022 2:56:59 AM falls between 10/16/2022 1:15:28 PM and 10/25/2022 2:56:59 AM.
IsRegressionStdDev: Marked as regression because -66.11849150973441 (T) = (0 -32708.891793890973) / Math.Sqrt((36497.739747544016 / (15)) + (39157.55655770188 / (26))) is less than -2.0226909200346674 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (15) + (26) - 2, .025) and -0.14530655722566518 = (28559.071444699835 - 32708.891793890973) / 28559.071444699835 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@kotlarmilos
Copy link
Member

Hey @eiriktsarpalis, looks like regression - dotnet/runtime@fe921e0

Could you take a look?

@eiriktsarpalis
Copy link
Member

Duplicate of dotnet/runtime#77279. Regression was introduced intentionally for those scenaria.

@kotlarmilos kotlarmilos mentioned this issue Oct 26, 2022
Closed
@eiriktsarpalis
Copy link
Member

In other words, this issue should be closed. Don't have permissions to do it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-x64 branch-refs/heads/main kind-micro_mono mono-interpreter os-linux perf-regression runtime-mono
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eiriktsarpalis @kotlarmilos